-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Match labels to trackbars according to RGB order #5136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Matched Label2 with Green value, and Label3 with Blue value in accordance with RGB order (1,2,3), and also to match the trackbar numbers (1,2,3). Improves readability and lowers risk of confusion.
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
|
Docs Build status updates of commit afa79d6: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
|
@TarenLewis I don't actually see that the code you modified is used in the documentation anywhere, only snippet4 (lines 64-93). Were you just browsing the code when you noticed this? |
|
@gewarren Yes, I noticed this "issue" in the documentation located here: label1 --> trackbar1 Thats why I swapped the coordinates, and renamed the labels accordingly to fit RGB order and "better" naming conventions. The code seemed confusing to me when I first looked at it, that's why I did this. |
|
I see it now, thanks. One problem is that the C++ and VB snippets still have the previous order of the labels. Could you update those too? |
|
Yes, I will take care of those fixes as well. |
|
@TarenLewis Are you still working on the VB/C++ snippets? Could you add them to this PR? |
|
Closing in favor of #9997. |
Summary
Matched Label2 with Green value, and Label3 with Blue value in accordance with RGB order (1,2,3), and also to match the trackbar numbers (1,2,3). Improves readability and lowers risk of confusion.