Skip to content

Conversation

@TarenLewis
Copy link

Summary

Matched Label2 with Green value, and Label3 with Blue value in accordance with RGB order (1,2,3), and also to match the trackbar numbers (1,2,3). Improves readability and lowers risk of confusion.

Matched Label2 with Green value, and Label3 with Blue value in accordance with RGB order (1,2,3), and also to match the trackbar numbers (1,2,3). Improves readability and lowers risk of confusion.
@Dotnet-GitSync-Bot
Copy link
Collaborator

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@opbld32
Copy link

opbld32 commented Nov 21, 2020

Docs Build status updates of commit afa79d6:

✅ Validation status: passed

File Status Preview URL Details
samples/snippets/csharp/VS_Snippets_Winforms/Trackbar/CS/form1.cs ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@gewarren
Copy link
Contributor

@TarenLewis I don't actually see that the code you modified is used in the documentation anywhere, only snippet4 (lines 64-93). Were you just browsing the code when you noticed this?

@gewarren gewarren requested a review from safern December 17, 2020 04:42
@TarenLewis
Copy link
Author

@gewarren Yes, I noticed this "issue" in the documentation located here:
https://docs.microsoft.com/en-us/dotnet/api/system.windows.forms.trackbar.scroll?view=netcore-3.1
It seems counterintuitive to me that the naming conventions would be:

label1 --> trackbar1
label3 --> trackbar2
label2 --> trackbar3

Thats why I swapped the coordinates, and renamed the labels accordingly to fit RGB order and "better" naming conventions. The code seemed confusing to me when I first looked at it, that's why I did this.

@gewarren
Copy link
Contributor

I see it now, thanks. One problem is that the C++ and VB snippets still have the previous order of the labels. Could you update those too?

@TarenLewis
Copy link
Author

Yes, I will take care of those fixes as well.

@eiriktsarpalis eiriktsarpalis added the area-WinForms Issues or PRs that relate to WinForms. label Feb 25, 2021
Base automatically changed from master to main March 5, 2021 20:52
@gewarren gewarren requested a review from a team as a code owner March 5, 2021 20:52
@gewarren
Copy link
Contributor

gewarren commented Mar 8, 2021

@TarenLewis Are you still working on the VB/C++ snippets? Could you add them to this PR?

@gewarren gewarren removed the request for review from safern June 5, 2024 17:08
@gewarren
Copy link
Contributor

gewarren commented Jun 5, 2024

Closing in favor of #9997.

@gewarren gewarren closed this Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-WinForms Issues or PRs that relate to WinForms.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants