From 0e0127bd503ca4c3ef4aca036146dbd11b3f57e9 Mon Sep 17 00:00:00 2001 From: carlossanlop Date: Fri, 3 Sep 2021 01:59:35 -0700 Subject: [PATCH 1/4] Port System.Runtime.Versioning.RequiresPreviewFeaturesAttribute triple slash to docs --- .../RequiresPreviewFeaturesAttribute.xml | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/xml/System.Runtime.Versioning/RequiresPreviewFeaturesAttribute.xml b/xml/System.Runtime.Versioning/RequiresPreviewFeaturesAttribute.xml index 1aea749e11e..46acea07138 100644 --- a/xml/System.Runtime.Versioning/RequiresPreviewFeaturesAttribute.xml +++ b/xml/System.Runtime.Versioning/RequiresPreviewFeaturesAttribute.xml @@ -20,7 +20,7 @@ - To be added. + An attribute to decorate features that are in preview mode. To be added. @@ -57,8 +57,8 @@ - To be added. - To be added. + An optional message associated with this attribute instance. + Initializes a new instance of the class with the specified message. To be added. @@ -78,7 +78,7 @@ System.String - To be added. + Returns the optional message associated with this attribute instance. To be added. To be added. @@ -99,7 +99,7 @@ System.String - To be added. + Returns the optional URL associated with this attribute instance. To be added. To be added. From 3f568e1566690ae13c93d2977dd907273dbff8a1 Mon Sep 17 00:00:00 2001 From: Carlos Sanchez <1175054+carlossanlop@users.noreply.github.com> Date: Fri, 3 Sep 2021 11:36:53 -0700 Subject: [PATCH 2/4] suggestion by pgovind --- .../RequiresPreviewFeaturesAttribute.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xml/System.Runtime.Versioning/RequiresPreviewFeaturesAttribute.xml b/xml/System.Runtime.Versioning/RequiresPreviewFeaturesAttribute.xml index 46acea07138..df890452fc9 100644 --- a/xml/System.Runtime.Versioning/RequiresPreviewFeaturesAttribute.xml +++ b/xml/System.Runtime.Versioning/RequiresPreviewFeaturesAttribute.xml @@ -20,7 +20,7 @@ - An attribute to decorate features that are in preview mode. + This attribute declares an API to be Preview and allows call sites to be flagged with a diagnostic indicating Preview API usage. Authors can use this attribute to ship Preview features in their assemblies. To be added. From 5d8601068db28817c4f2012bec0f49e028fd1acd Mon Sep 17 00:00:00 2001 From: Carlos Sanchez <1175054+carlossanlop@users.noreply.github.com> Date: Fri, 3 Sep 2021 11:44:39 -0700 Subject: [PATCH 3/4] add link --- .../RequiresPreviewFeaturesAttribute.xml | 1 + 1 file changed, 1 insertion(+) diff --git a/xml/System.Runtime.Versioning/RequiresPreviewFeaturesAttribute.xml b/xml/System.Runtime.Versioning/RequiresPreviewFeaturesAttribute.xml index df890452fc9..ffed4320865 100644 --- a/xml/System.Runtime.Versioning/RequiresPreviewFeaturesAttribute.xml +++ b/xml/System.Runtime.Versioning/RequiresPreviewFeaturesAttribute.xml @@ -22,6 +22,7 @@ This attribute declares an API to be Preview and allows call sites to be flagged with a diagnostic indicating Preview API usage. Authors can use this attribute to ship Preview features in their assemblies. To be added. + Preview Features From c142d849c91f0ea1e460729eb91dc31656c6478d Mon Sep 17 00:00:00 2001 From: Carlos Sanchez <1175054+carlossanlop@users.noreply.github.com> Date: Wed, 8 Sep 2021 12:49:06 -0700 Subject: [PATCH 4/4] Apply suggestions from code review Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com> --- .../RequiresPreviewFeaturesAttribute.xml | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/xml/System.Runtime.Versioning/RequiresPreviewFeaturesAttribute.xml b/xml/System.Runtime.Versioning/RequiresPreviewFeaturesAttribute.xml index ffed4320865..e0df9897931 100644 --- a/xml/System.Runtime.Versioning/RequiresPreviewFeaturesAttribute.xml +++ b/xml/System.Runtime.Versioning/RequiresPreviewFeaturesAttribute.xml @@ -20,9 +20,9 @@ - This attribute declares an API to be Preview and allows call sites to be flagged with a diagnostic indicating Preview API usage. Authors can use this attribute to ship Preview features in their assemblies. + Indicates that an API is in preview. This attribute allows call sites to be flagged with a diagnostic that indicates that a preview feature is used. Authors can use this attribute to ship preview features in their assemblies. To be added. - Preview Features + Preview Features @@ -59,7 +59,7 @@ An optional message associated with this attribute instance. - Initializes a new instance of the class with the specified message. + Initializes a new instance of the class with the specified message. To be added. @@ -79,7 +79,7 @@ System.String - Returns the optional message associated with this attribute instance. + Gets the optional message associated with this attribute instance. To be added. To be added. @@ -100,7 +100,7 @@ System.String - Returns the optional URL associated with this attribute instance. + Gets or sets the optional URL associated with this attribute instance. To be added. To be added.