From 25eb44925cd70d1785cf465610c5916779370957 Mon Sep 17 00:00:00 2001 From: carlossanlop Date: Thu, 9 Sep 2021 13:33:22 -0700 Subject: [PATCH 1/3] Port IntPtr and MemoryExtensions triple slash to docs --- xml/System/IntPtr.xml | 13 ++--- ...ions+TryWriteInterpolatedStringHandler.xml | 53 ++++++++++--------- 2 files changed, 34 insertions(+), 32 deletions(-) diff --git a/xml/System/IntPtr.xml b/xml/System/IntPtr.xml index 6f11c818544..e1ba327865d 100644 --- a/xml/System/IntPtr.xml +++ b/xml/System/IntPtr.xml @@ -2193,12 +2193,13 @@ This member is an explicit interface member implementation. It can be used only - To be added. - To be added. - To be added. - To be added. - To be added. - To be added. + When this method returns, this instance's value formatted as a span of characters. + When this method returns, the number of characters that were written in . + A span containing the characters that represent a standard or custom format string that defines the acceptable format for . + An optional object that supplies culture-specific formatting information for . + Tries to format the value of the current instance into the provided span of characters. + + if the formatting was successful; otherwise, . To be added. diff --git a/xml/System/MemoryExtensions+TryWriteInterpolatedStringHandler.xml b/xml/System/MemoryExtensions+TryWriteInterpolatedStringHandler.xml index 0c3b433675b..12fc707270a 100644 --- a/xml/System/MemoryExtensions+TryWriteInterpolatedStringHandler.xml +++ b/xml/System/MemoryExtensions+TryWriteInterpolatedStringHandler.xml @@ -31,7 +31,7 @@ - To be added. + Provides a handler used by the language compiler to format interpolated strings into character spans. To be added. @@ -135,8 +135,8 @@ - To be added. - To be added. + The value to write. + Writes the specified value to the handler. To be added. To be added. @@ -161,10 +161,10 @@ - To be added. - To be added. - To be added. - To be added. + The value to write. + Minimum number of characters that should be written for this value. If the value is negative, it indicates left-aligned and the required minimum is the absolute value. + The format string. + Writes the specified value to the handler. To be added. To be added. @@ -217,10 +217,10 @@ - To be added. - To be added. - To be added. - To be added. + The value to write. + Minimum number of characters that should be written for this value. If the value is negative, it indicates left-aligned and the required minimum is the absolute value. + The format string. + Writes the specified value to the handler. To be added. To be added. @@ -248,8 +248,8 @@ To be added. - To be added. - To be added. + The value to write. + Writes the specified value to the handler. To be added. To be added. @@ -278,9 +278,9 @@ To be added. - To be added. - To be added. - To be added. + The value to write. + Minimum number of characters that should be written for this value. If the value is negative, it indicates left-aligned and the required minimum is the absolute value. + Writes the specified value to the handler. To be added. To be added. @@ -309,9 +309,9 @@ To be added. - To be added. - To be added. - To be added. + The value to write. + The format string. + Writes the specified value to the handler. To be added. To be added. @@ -341,10 +341,10 @@ To be added. - To be added. - To be added. - To be added. - To be added. + The value to write. + Minimum number of characters that should be written for this value. If the value is negative, it indicates left-aligned and the required minimum is the absolute value. + The format string. + Writes the specified value to the handler. To be added. To be added. @@ -368,9 +368,10 @@ - To be added. - To be added. - To be added. + The string to write. + Writes the specified string to the handler. + + if the value could be formatted to the span; otherwise, . To be added. From c70e17004ad111ecc32e676dee579a050640ffa3 Mon Sep 17 00:00:00 2001 From: Carlos Sanchez <1175054+carlossanlop@users.noreply.github.com> Date: Thu, 9 Sep 2021 13:46:09 -0700 Subject: [PATCH 2/3] Apply suggestions from code review --- ...ions+TryWriteInterpolatedStringHandler.xml | 20 +++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/xml/System/MemoryExtensions+TryWriteInterpolatedStringHandler.xml b/xml/System/MemoryExtensions+TryWriteInterpolatedStringHandler.xml index 12fc707270a..a2bf57a064e 100644 --- a/xml/System/MemoryExtensions+TryWriteInterpolatedStringHandler.xml +++ b/xml/System/MemoryExtensions+TryWriteInterpolatedStringHandler.xml @@ -137,7 +137,7 @@ The value to write. Writes the specified value to the handler. - To be added. + on success; otherwise. To be added. @@ -165,7 +165,7 @@ Minimum number of characters that should be written for this value. If the value is negative, it indicates left-aligned and the required minimum is the absolute value. The format string. Writes the specified value to the handler. - To be added. + on success; otherwise. To be added. @@ -221,7 +221,7 @@ Minimum number of characters that should be written for this value. If the value is negative, it indicates left-aligned and the required minimum is the absolute value. The format string. Writes the specified value to the handler. - To be added. + on success; otherwise. To be added. @@ -247,10 +247,10 @@ - To be added. + The type of the value to write. The value to write. Writes the specified value to the handler. - To be added. + on success; otherwise. To be added. @@ -277,7 +277,7 @@ - To be added. + The type of the value to write. The value to write. Minimum number of characters that should be written for this value. If the value is negative, it indicates left-aligned and the required minimum is the absolute value. Writes the specified value to the handler. @@ -308,11 +308,11 @@ - To be added. + The type of the value to write. The value to write. The format string. Writes the specified value to the handler. - To be added. + on success; otherwise. To be added. @@ -340,12 +340,12 @@ - To be added. + The type of the value to write. The value to write. Minimum number of characters that should be written for this value. If the value is negative, it indicates left-aligned and the required minimum is the absolute value. The format string. Writes the specified value to the handler. - To be added. + on success; otherwise. To be added. From c8f5fd45af8b92386fbb0fa72a02ecc78cd20973 Mon Sep 17 00:00:00 2001 From: Carlos Sanchez <1175054+carlossanlop@users.noreply.github.com> Date: Thu, 9 Sep 2021 14:23:20 -0700 Subject: [PATCH 3/3] Apply suggestions from code review Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com> --- xml/System/IntPtr.xml | 6 +++--- ...xtensions+TryWriteInterpolatedStringHandler.xml | 14 +++++++------- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/xml/System/IntPtr.xml b/xml/System/IntPtr.xml index e1ba327865d..893532131f2 100644 --- a/xml/System/IntPtr.xml +++ b/xml/System/IntPtr.xml @@ -2193,9 +2193,9 @@ This member is an explicit interface member implementation. It can be used only - When this method returns, this instance's value formatted as a span of characters. - When this method returns, the number of characters that were written in . - A span containing the characters that represent a standard or custom format string that defines the acceptable format for . + The span where this instance's value formatted as a span of characters should be written. + When this method returns, contains the number of characters that were written in . + The characters that represent a standard or custom format string that defines the acceptable format for . An optional object that supplies culture-specific formatting information for . Tries to format the value of the current instance into the provided span of characters. diff --git a/xml/System/MemoryExtensions+TryWriteInterpolatedStringHandler.xml b/xml/System/MemoryExtensions+TryWriteInterpolatedStringHandler.xml index a2bf57a064e..6f597d16579 100644 --- a/xml/System/MemoryExtensions+TryWriteInterpolatedStringHandler.xml +++ b/xml/System/MemoryExtensions+TryWriteInterpolatedStringHandler.xml @@ -162,7 +162,7 @@ The value to write. - Minimum number of characters that should be written for this value. If the value is negative, it indicates left-aligned and the required minimum is the absolute value. + The minimum number of characters that should be written for this value. A negative value indicates left-aligned, and the required minimum is the absolute value. The format string. Writes the specified value to the handler. on success; otherwise. @@ -218,9 +218,9 @@ The value to write. - Minimum number of characters that should be written for this value. If the value is negative, it indicates left-aligned and the required minimum is the absolute value. + The minimum number of characters that should be written for this value. A negative value indicates left-aligned, and the required minimum is the absolute value. The format string. - Writes the specified value to the handler. + Writes a specified value to the handler using a specified format string. on success; otherwise. To be added. @@ -279,7 +279,7 @@ The type of the value to write. The value to write. - Minimum number of characters that should be written for this value. If the value is negative, it indicates left-aligned and the required minimum is the absolute value. + The minimum number of characters that should be written for this value.A negative value indicates left-aligned, and the required minimum is the absolute value. Writes the specified value to the handler. To be added. To be added. @@ -311,7 +311,7 @@ The type of the value to write. The value to write. The format string. - Writes the specified value to the handler. + Writes a specified value to the handler using a specified format string. on success; otherwise. To be added. @@ -342,9 +342,9 @@ The type of the value to write. The value to write. - Minimum number of characters that should be written for this value. If the value is negative, it indicates left-aligned and the required minimum is the absolute value. + The minimum number of characters that should be written for this value. A negative value indicates left-aligned, and the required minimum is the absolute value. The format string. - Writes the specified value to the handler. + Writes a specified value to the handler using a specified format string. on success; otherwise. To be added.