From 2f5d4b26cb12ab28b8f061cf1b24c1b39b70525c Mon Sep 17 00:00:00 2001 From: softwarepronto Date: Sat, 22 Oct 2022 05:16:30 -0700 Subject: [PATCH 1/3] Missing use for Stream and StreamReader variables The WebClient variable has a using Using client As New WebClient() These were missing the using: Ref data As Stream = client.OpenRead(args(0)) Ref reader As New StreamReader(data) The order of Close for reader.Close and data.Close was reversed. --- .../NCLWebClientUserAgent/VB/useragent.vb | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/snippets/visualbasic/VS_Snippets_Remoting/NCLWebClientUserAgent/VB/useragent.vb b/snippets/visualbasic/VS_Snippets_Remoting/NCLWebClientUserAgent/VB/useragent.vb index a134fda4ae4..951a0a67d88 100644 --- a/snippets/visualbasic/VS_Snippets_Remoting/NCLWebClientUserAgent/VB/useragent.vb +++ b/snippets/visualbasic/VS_Snippets_Remoting/NCLWebClientUserAgent/VB/useragent.vb @@ -16,13 +16,13 @@ Public Class Test ' requested URI contains a query. client.Headers.Add("user-agent", "Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.2; .NET CLR 1.0.3705;)") - Dim data As Stream = client.OpenRead(args(0)) - Dim reader As New StreamReader(data) + Using data As Stream = client.OpenRead(args(0)) + Using reader As New StreamReader(data) Dim s As String = reader.ReadToEnd() Console.WriteLine(s) - data.Close() reader.Close() + data.Close() End Using End Sub End Class -' \ No newline at end of file +' From 623f146b198378c18c7bbdf033ee1353da509de1 Mon Sep 17 00:00:00 2001 From: softwarepronto Date: Sat, 22 Oct 2022 05:50:36 -0700 Subject: [PATCH 2/3] Missed End Using End Using need for VB.net --- .../NCLWebClientUserAgent/VB/useragent.vb | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/snippets/visualbasic/VS_Snippets_Remoting/NCLWebClientUserAgent/VB/useragent.vb b/snippets/visualbasic/VS_Snippets_Remoting/NCLWebClientUserAgent/VB/useragent.vb index 951a0a67d88..0b713873170 100644 --- a/snippets/visualbasic/VS_Snippets_Remoting/NCLWebClientUserAgent/VB/useragent.vb +++ b/snippets/visualbasic/VS_Snippets_Remoting/NCLWebClientUserAgent/VB/useragent.vb @@ -17,11 +17,13 @@ Public Class Test client.Headers.Add("user-agent", "Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.2; .NET CLR 1.0.3705;)") Using data As Stream = client.OpenRead(args(0)) - Using reader As New StreamReader(data) - Dim s As String = reader.ReadToEnd() - Console.WriteLine(s) - reader.Close() - data.Close() + Using reader As New StreamReader(data) + Dim s As String = reader.ReadToEnd() + Console.WriteLine(s) + reader.Close() + End Using + data.Close() + End Using End Using End Sub End Class From 695087d22d7d4ae6f92b956cf31fe1ea640d2578 Mon Sep 17 00:00:00 2001 From: Bill Wagner Date: Tue, 25 Oct 2022 09:20:33 -0400 Subject: [PATCH 3/3] Apply suggestions from code review --- .../VS_Snippets_Remoting/NCLWebClientUserAgent/VB/useragent.vb | 2 -- 1 file changed, 2 deletions(-) diff --git a/snippets/visualbasic/VS_Snippets_Remoting/NCLWebClientUserAgent/VB/useragent.vb b/snippets/visualbasic/VS_Snippets_Remoting/NCLWebClientUserAgent/VB/useragent.vb index 0b713873170..b1653fe4419 100644 --- a/snippets/visualbasic/VS_Snippets_Remoting/NCLWebClientUserAgent/VB/useragent.vb +++ b/snippets/visualbasic/VS_Snippets_Remoting/NCLWebClientUserAgent/VB/useragent.vb @@ -20,9 +20,7 @@ Public Class Test Using reader As New StreamReader(data) Dim s As String = reader.ReadToEnd() Console.WriteLine(s) - reader.Close() End Using - data.Close() End Using End Using End Sub