Port over more doc comments #9169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A lot of these had issues porting over, so some of them were manually ported. I added the default constructor docs here directly so we didn't have to add default constructors into the C# source. This is primarily System.Runtime.InteropServices docs, with some other docs automatically ported over as part of the process.
jkoritzinsky
requested review from
carlossanlop,
gewarren,
jtschuster and
elinor-fung
ghost
assigned 
|
Learn Build status updates of commit 24a8bf6: 💡 Validation status: suggestionsxml/System.Runtime.InteropServices.Marshalling/ComObject.xml
For more details, please refer to the build report. Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them. For any questions, please:
|
|
Learn Build status updates of commit 11a8137: 💡 Validation status: suggestionsxml/System.Runtime.InteropServices.Marshalling/ComObject.xml
For more details, please refer to the build report. Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them. For any questions, please:
|
gewarren
approved these changes
Jul 28, 2023
xml/System.Runtime.InteropServices.Marshalling/ComExposedClassAttribute`1.xml
Outdated
Show resolved
Hide resolved
xml/System.Runtime.InteropServices.Marshalling/ComExposedClassAttribute`1.xml
Outdated
Show resolved
Hide resolved
xml/System.Runtime.InteropServices.Marshalling/ComInterfaceMarshaller`1.xml
Outdated
Show resolved
Hide resolved
xml/System.Runtime.InteropServices.Marshalling/GeneratedComClassAttribute.xml
Outdated
Show resolved
Hide resolved
xml/System.Runtime.InteropServices.Marshalling/GeneratedComInterfaceAttribute.xml
Outdated
Show resolved
Hide resolved
xml/System.Runtime.InteropServices.Marshalling/UniqueComInterfaceMarshaller`1.xml
Outdated
Show resolved
Hide resolved
xml/System.Runtime.InteropServices/ImmutableCollectionsMarshal.xml
Outdated
Show resolved
Hide resolved
xml/System.Runtime.InteropServices/ImmutableCollectionsMarshal.xml
Outdated
Show resolved
Hide resolved
xml/System.Runtime.InteropServices/ImmutableCollectionsMarshal.xml
Outdated
Show resolved
Hide resolved
xml/System.Runtime.InteropServices/ImmutableCollectionsMarshal.xml
Outdated
Show resolved
Hide resolved
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
|
Learn Build status updates of commit 925f01d: 💡 Validation status: suggestionsxml/System.Runtime.InteropServices.Marshalling/ComObject.xml
For more details, please refer to the build report. Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them. For any questions, please:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of these had issues porting over, so some of them were manually ported. I added the default constructor docs here directly so we didn't have to add default constructors into the C# source.
This is primarily System.Runtime.InteropServices docs, with some other docs automatically ported over as part of the process.
Summary
Contributes to dotnet/runtime#88573, dotnet/runtime#88565, dotnet/runtime#88569
This should cover the remaining APIs in dotnet/runtime#88573 (I went through the table manually to make sure I got them), but I don't want to close the issue until I have confirmation from @carlossanlop that I got all of them.