From dc1edf24fffc1652474cb50a0ccb5cfe7457c12a Mon Sep 17 00:00:00 2001 From: Genevieve Warren <24882762+gewarren@users.noreply.github.com> Date: Fri, 22 Sep 2023 15:14:11 -0700 Subject: [PATCH 1/5] update remarks and exceptions for maxby/minby --- xml/System.Linq/Enumerable.xml | 48 +++++++++------------------------- 1 file changed, 12 insertions(+), 36 deletions(-) diff --git a/xml/System.Linq/Enumerable.xml b/xml/System.Linq/Enumerable.xml index 196fd843e0b..5b13509a0ed 100644 --- a/xml/System.Linq/Enumerable.xml +++ b/xml/System.Linq/Enumerable.xml @@ -8257,18 +8257,12 @@ In Visual Basic query expression syntax, an `Aggregate Into Max()` clause transl A function to extract the key for each element. Returns the maximum value in a generic sequence according to a specified key selector function. The value with the maximum key in the sequence. - - - + If is a reference type and the source sequence is empty or contains only values that are , this method returns . is . No key extracted from implements the or interface. + + is a primitive type and the source sequence is empty. @@ -8338,18 +8332,12 @@ If `TKey` is a reference type and the source sequence is empty or contains only The to compare keys. Returns the maximum value in a generic sequence according to a specified key selector function and key comparer. The value with the maximum key in the sequence. - - - + If is a reference type and the source sequence is empty or contains only values that are , this method returns . is . No key extracted from implements the or interface. + + is a primitive type and the source sequence is empty. @@ -10061,18 +10049,12 @@ In Visual Basic query expression syntax, an `Aggregate Into Min()` clause transl A function to extract the key for each element. Returns the minimum value in a generic sequence according to a specified key selector function. The value with the minimum key in the sequence. - - - + If is a reference type and the source sequence is empty or contains only values that are , this method returns . is . No key extracted from implements the or interface. + + is a primitive type and the source sequence is empty. @@ -10142,18 +10124,12 @@ If `TKey` is a reference type and the source sequence is empty or contains only The to compare keys. Returns the minimum value in a generic sequence according to a specified key selector function and key comparer. The value with the minimum key in the sequence. - - - + If is a reference type and the source sequence is empty or contains only values that are , this method returns . is . No key extracted from implements the or interface. + + is a primitive type and the source sequence is empty. From e0f391c490ce8d8c334ef3202925728f73fd4d84 Mon Sep 17 00:00:00 2001 From: Genevieve Warren <24882762+gewarren@users.noreply.github.com> Date: Mon, 25 Sep 2023 11:04:32 -0700 Subject: [PATCH 2/5] add exception to remarks --- xml/System.Linq/Enumerable.xml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/xml/System.Linq/Enumerable.xml b/xml/System.Linq/Enumerable.xml index 5b13509a0ed..1cc9dd0ffe1 100644 --- a/xml/System.Linq/Enumerable.xml +++ b/xml/System.Linq/Enumerable.xml @@ -8257,7 +8257,7 @@ In Visual Basic query expression syntax, an `Aggregate Into Max()` clause transl A function to extract the key for each element. Returns the maximum value in a generic sequence according to a specified key selector function. The value with the maximum key in the sequence. - If is a reference type and the source sequence is empty or contains only values that are , this method returns . + If is a reference type and the source sequence is empty or contains only values that are , this method returns . If is a primitive type and the source sequence is empty, an is thrown. is . No key extracted from implements the or interface. @@ -8332,7 +8332,7 @@ In Visual Basic query expression syntax, an `Aggregate Into Max()` clause transl The to compare keys. Returns the maximum value in a generic sequence according to a specified key selector function and key comparer. The value with the maximum key in the sequence. - If is a reference type and the source sequence is empty or contains only values that are , this method returns . + If is a reference type and the source sequence is empty or contains only values that are , this method returns . If is a primitive type and the source sequence is empty, an is thrown. is . No key extracted from implements the or interface. @@ -10049,7 +10049,7 @@ In Visual Basic query expression syntax, an `Aggregate Into Min()` clause transl A function to extract the key for each element. Returns the minimum value in a generic sequence according to a specified key selector function. The value with the minimum key in the sequence. - If is a reference type and the source sequence is empty or contains only values that are , this method returns . + If is a reference type and the source sequence is empty or contains only values that are , this method returns . If is a primitive type and the source sequence is empty, an is thrown. is . No key extracted from implements the or interface. @@ -10124,7 +10124,7 @@ In Visual Basic query expression syntax, an `Aggregate Into Min()` clause transl The to compare keys. Returns the minimum value in a generic sequence according to a specified key selector function and key comparer. The value with the minimum key in the sequence. - If is a reference type and the source sequence is empty or contains only values that are , this method returns . + If is a reference type and the source sequence is empty or contains only values that are , this method returns . If is a primitive type and the source sequence is empty, an is thrown. is . No key extracted from implements the or interface. From 9d3124faf7c21ea7d1908ae386dfa11aa3f4240e Mon Sep 17 00:00:00 2001 From: Genevieve Warren <24882762+gewarren@users.noreply.github.com> Date: Mon, 25 Sep 2023 11:13:34 -0700 Subject: [PATCH 3/5] add closing tag --- xml/System.Linq/Enumerable.xml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/xml/System.Linq/Enumerable.xml b/xml/System.Linq/Enumerable.xml index 1cc9dd0ffe1..dfabd2156dc 100644 --- a/xml/System.Linq/Enumerable.xml +++ b/xml/System.Linq/Enumerable.xml @@ -8257,7 +8257,7 @@ In Visual Basic query expression syntax, an `Aggregate Into Max()` clause transl A function to extract the key for each element. Returns the maximum value in a generic sequence according to a specified key selector function. The value with the maximum key in the sequence. - If is a reference type and the source sequence is empty or contains only values that are , this method returns . If is a primitive type and the source sequence is empty, an is thrown. + If is a reference type and the source sequence is empty or contains only values that are , this method returns . If is a primitive type and the source sequence is empty, an is thrown. is . No key extracted from implements the or interface. @@ -8332,7 +8332,7 @@ In Visual Basic query expression syntax, an `Aggregate Into Max()` clause transl The to compare keys. Returns the maximum value in a generic sequence according to a specified key selector function and key comparer. The value with the maximum key in the sequence. - If is a reference type and the source sequence is empty or contains only values that are , this method returns . If is a primitive type and the source sequence is empty, an is thrown. + If is a reference type and the source sequence is empty or contains only values that are , this method returns . If is a primitive type and the source sequence is empty, an is thrown. is . No key extracted from implements the or interface. @@ -10049,7 +10049,7 @@ In Visual Basic query expression syntax, an `Aggregate Into Min()` clause transl A function to extract the key for each element. Returns the minimum value in a generic sequence according to a specified key selector function. The value with the minimum key in the sequence. - If is a reference type and the source sequence is empty or contains only values that are , this method returns . If is a primitive type and the source sequence is empty, an is thrown. + If is a reference type and the source sequence is empty or contains only values that are , this method returns . If is a primitive type and the source sequence is empty, an is thrown. is . No key extracted from implements the or interface. @@ -10124,7 +10124,7 @@ In Visual Basic query expression syntax, an `Aggregate Into Min()` clause transl The to compare keys. Returns the minimum value in a generic sequence according to a specified key selector function and key comparer. The value with the minimum key in the sequence. - If is a reference type and the source sequence is empty or contains only values that are , this method returns . If is a primitive type and the source sequence is empty, an is thrown. + If is a reference type and the source sequence is empty or contains only values that are , this method returns . If is a primitive type and the source sequence is empty, an is thrown. is . No key extracted from implements the or interface. From d452d9428c3c50a0afd8e3a5c18785dea5c9da02 Mon Sep 17 00:00:00 2001 From: Genevieve Warren <24882762+gewarren@users.noreply.github.com> Date: Mon, 25 Sep 2023 12:24:00 -0700 Subject: [PATCH 4/5] fix tags --- xml/System.Linq/Enumerable.xml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/xml/System.Linq/Enumerable.xml b/xml/System.Linq/Enumerable.xml index dfabd2156dc..adfefa77277 100644 --- a/xml/System.Linq/Enumerable.xml +++ b/xml/System.Linq/Enumerable.xml @@ -8257,7 +8257,7 @@ In Visual Basic query expression syntax, an `Aggregate Into Max()` clause transl A function to extract the key for each element. Returns the maximum value in a generic sequence according to a specified key selector function. The value with the maximum key in the sequence. - If is a reference type and the source sequence is empty or contains only values that are , this method returns . If is a primitive type and the source sequence is empty, an is thrown. + If is a reference type and the source sequence is empty or contains only values that are , this method returns . If is a primitive type and the source sequence is empty, an is thrown. is . No key extracted from implements the or interface. @@ -8332,7 +8332,7 @@ In Visual Basic query expression syntax, an `Aggregate Into Max()` clause transl The to compare keys. Returns the maximum value in a generic sequence according to a specified key selector function and key comparer. The value with the maximum key in the sequence. - If is a reference type and the source sequence is empty or contains only values that are , this method returns . If is a primitive type and the source sequence is empty, an is thrown. + If is a reference type and the source sequence is empty or contains only values that are , this method returns . If is a primitive type and the source sequence is empty, an is thrown. is . No key extracted from implements the or interface. @@ -10049,7 +10049,7 @@ In Visual Basic query expression syntax, an `Aggregate Into Min()` clause transl A function to extract the key for each element. Returns the minimum value in a generic sequence according to a specified key selector function. The value with the minimum key in the sequence. - If is a reference type and the source sequence is empty or contains only values that are , this method returns . If is a primitive type and the source sequence is empty, an is thrown. + If is a reference type and the source sequence is empty or contains only values that are , this method returns . If is a primitive type and the source sequence is empty, an is thrown. is . No key extracted from implements the or interface. @@ -10124,7 +10124,7 @@ In Visual Basic query expression syntax, an `Aggregate Into Min()` clause transl The to compare keys. Returns the minimum value in a generic sequence according to a specified key selector function and key comparer. The value with the minimum key in the sequence. - If is a reference type and the source sequence is empty or contains only values that are , this method returns . If is a primitive type and the source sequence is empty, an is thrown. + If is a reference type and the source sequence is empty or contains only values that are , this method returns . If is a primitive type and the source sequence is empty, an is thrown. is . No key extracted from implements the or interface. From 9dd70487bd2ed28f2ef647b6057be1d327ece12d Mon Sep 17 00:00:00 2001 From: Genevieve Warren <24882762+gewarren@users.noreply.github.com> Date: Tue, 26 Sep 2023 13:00:16 -0700 Subject: [PATCH 5/5] respond to feedback --- xml/System.Linq/Enumerable.xml | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/xml/System.Linq/Enumerable.xml b/xml/System.Linq/Enumerable.xml index adfefa77277..1d6acf7b417 100644 --- a/xml/System.Linq/Enumerable.xml +++ b/xml/System.Linq/Enumerable.xml @@ -8257,7 +8257,8 @@ In Visual Basic query expression syntax, an `Aggregate Into Max()` clause transl A function to extract the key for each element. Returns the maximum value in a generic sequence according to a specified key selector function. The value with the maximum key in the sequence. - If is a reference type and the source sequence is empty or contains only values that are , this method returns . If is a primitive type and the source sequence is empty, an is thrown. + If the source sequence is empty and is a nullable type, this method returns . If the source sequence is empty and is a non-nullable struct, such as a primitive type, an is thrown. + If the source sequence contains only values that are . is . No key extracted from implements the or interface. @@ -8332,7 +8333,8 @@ In Visual Basic query expression syntax, an `Aggregate Into Max()` clause transl The to compare keys. Returns the maximum value in a generic sequence according to a specified key selector function and key comparer. The value with the maximum key in the sequence. - If is a reference type and the source sequence is empty or contains only values that are , this method returns . If is a primitive type and the source sequence is empty, an is thrown. + If the source sequence is empty and is a nullable type, this method returns . If the source sequence is empty and is a non-nullable struct, such as a primitive type, an is thrown. + If the source sequence contains only values that are . is . No key extracted from implements the or interface. @@ -10049,7 +10051,8 @@ In Visual Basic query expression syntax, an `Aggregate Into Min()` clause transl A function to extract the key for each element. Returns the minimum value in a generic sequence according to a specified key selector function. The value with the minimum key in the sequence. - If is a reference type and the source sequence is empty or contains only values that are , this method returns . If is a primitive type and the source sequence is empty, an is thrown. + If the source sequence is empty and is a nullable type, this method returns . If the source sequence is empty and is a non-nullable struct, such as a primitive type, an is thrown. + If the source sequence contains only values that are . is . No key extracted from implements the or interface. @@ -10124,7 +10127,8 @@ In Visual Basic query expression syntax, an `Aggregate Into Min()` clause transl The to compare keys. Returns the minimum value in a generic sequence according to a specified key selector function and key comparer. The value with the minimum key in the sequence. - If is a reference type and the source sequence is empty or contains only values that are , this method returns . If is a primitive type and the source sequence is empty, an is thrown. + If the source sequence is empty and is a nullable type, this method returns . If the source sequence is empty and is a non-nullable struct, such as a primitive type, an is thrown. + If the source sequence contains only values that are . is . No key extracted from implements the or interface.