From 51a6eaccfd18666da4bbe18fd0d5e472a0da45cd Mon Sep 17 00:00:00 2001 From: skyoxZ Date: Wed, 29 Nov 2023 18:53:19 +0800 Subject: [PATCH 1/3] Fix docs about Min/MaxMagnitude{Number} --- xml/System.Numerics/INumberBase`1.xml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/xml/System.Numerics/INumberBase`1.xml b/xml/System.Numerics/INumberBase`1.xml index 9c306eb5cac..f5ba3fb5978 100644 --- a/xml/System.Numerics/INumberBase`1.xml +++ b/xml/System.Numerics/INumberBase`1.xml @@ -852,7 +852,7 @@ This function treats both positive and negative zero as zero and so will return The value to compare with . Compares two values to compute which has the greater magnitude. - if it is greater than ; otherwise, . + if it has the greater magnitude than ; otherwise, . this method matches the IEE The value to compare with . Compares two values to compute which has the greater magnitude and returning the other value if an input is NaN. - if it is greater than ; otherwise, . + if it has the greater magnitude than ; otherwise, . this method matches the IEE The value to compare with . Compares two values to compute which has the lesser magnitude. - if it is less than ; otherwise, . + if it has the lesser magnitude than ; otherwise, . this method matches the IEE The value to compare with . Compares two values to compute which has the lesser magnitude and returning the other value if an input is NaN. - if it is less than ; otherwise, . + if it has the lesser than ; otherwise, . Date: Wed, 29 Nov 2023 18:56:52 +0800 Subject: [PATCH 2/3] Fix missing word --- xml/System.Numerics/INumberBase`1.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xml/System.Numerics/INumberBase`1.xml b/xml/System.Numerics/INumberBase`1.xml index f5ba3fb5978..2b476d269a3 100644 --- a/xml/System.Numerics/INumberBase`1.xml +++ b/xml/System.Numerics/INumberBase`1.xml @@ -963,7 +963,7 @@ For this method matches the IEE The value to compare with . Compares two values to compute which has the lesser magnitude and returning the other value if an input is NaN. - if it has the lesser than ; otherwise, . + if it has the lesser magnitude than ; otherwise, . Date: Fri, 1 Dec 2023 13:30:53 -0500 Subject: [PATCH 3/3] Apply suggestions from code review Co-authored-by: Tanner Gooding --- xml/System.Numerics/INumberBase`1.xml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/xml/System.Numerics/INumberBase`1.xml b/xml/System.Numerics/INumberBase`1.xml index 2b476d269a3..b9a76f459c4 100644 --- a/xml/System.Numerics/INumberBase`1.xml +++ b/xml/System.Numerics/INumberBase`1.xml @@ -852,7 +852,7 @@ This function treats both positive and negative zero as zero and so will return The value to compare with . Compares two values to compute which has the greater magnitude. - if it has the greater magnitude than ; otherwise, . + if it has a greater magnitude than ; otherwise, . this method matches the IEE The value to compare with . Compares two values to compute which has the greater magnitude and returning the other value if an input is NaN. - if it has the greater magnitude than ; otherwise, . + if it has a greater magnitude than ; otherwise, . this method matches the IEE The value to compare with . Compares two values to compute which has the lesser magnitude. - if it has the lesser magnitude than ; otherwise, . + if it has a lesser magnitude than ; otherwise, . this method matches the IEE The value to compare with . Compares two values to compute which has the lesser magnitude and returning the other value if an input is NaN. - if it has the lesser magnitude than ; otherwise, . + if it has a lesser magnitude than ; otherwise, .