Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Arm64] Add runtime-dep and runtime images #509

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
4 participants
@sdmaclea
Copy link
Member

commented Apr 26, 2018

@MichaelSimons This should add 2.1 arm64 runtime-dep and runtime images.

I didn't add SDK yet because last I checked it was not working.

I'll see if linux-arm64 sdk 2.1.300-rc1-008662 is working.

@richlander @Petermarcu @RussKeldorph @dotnet/arm64-contrib FYI this is not intended to formally release linux-arm64, but to allow people to use docker to try arm64.

@sdmaclea sdmaclea force-pushed the sdmaclea:PR-ARM64-INITIAL branch from 6e1d6a2 to 187ac47 Apr 27, 2018

@sdmaclea

This comment has been minimized.

Copy link
Member Author

commented Apr 27, 2018

Added draft build-pipeline changes
Didn't include samples builds.

@@ -0,0 +1,17 @@
FROM microsoft/dotnet-nightly:2.1-runtime-deps-stretch-slim-arm32v7

This comment has been minimized.

Copy link
@etherealjoy

etherealjoy Apr 27, 2018

Is this OK the runtime deps are from arm32v7?
The tag below is 2.1-runtime-deps-stretch-slim-arm64v8

This comment has been minimized.

Copy link
@sdmaclea

sdmaclea Apr 27, 2018

Author Member

To many moving parts. It is hard to get them all right. I'll update the patch

@richlander

This comment has been minimized.

Copy link
Member

commented Apr 27, 2018

We should also consider adding Alpine at the same time ... https://hub.docker.com/r/arm64v8/alpine/

Thanks for doing this. We were just talking about adding ARM64 images. We're just deciding when we should merge, before or after 2.1 RTM.

@sdmaclea

This comment has been minimized.

Copy link
Member Author

commented Apr 27, 2018

@janvorli will be adding alpine dotnet builds for arm32 and arm64 soon. They probably will not work in 2.1

@sdmaclea sdmaclea force-pushed the sdmaclea:PR-ARM64-INITIAL branch from 187ac47 to 3f0739a Apr 27, 2018

@sdmaclea

This comment has been minimized.

Copy link
Member Author

commented Apr 27, 2018

before or after 2.1 RTM.

While linux-arm64 is not production ready on the 2.1 branch it is reasonably stable. The runtime should work for the vast majority of use cases. Unfortunately the SDK is not yet one of them. (linux-arm64 sdk 2.1.300-rc1-008662 fails)

I see no harm in having 2.1 docker runtime images. I also wouldn't be offended if this was moved to 2.2.

@richlander

This comment has been minimized.

Copy link
Member

commented Apr 27, 2018

@MichaelSimons and I just talked. We're happy to merge this into the nightly branch, but only if it is for 2.2, for three reasons:

  • All future ARM64 work is in 2.2. We won't service 2.1 for ARM64.
  • We don't want to have two different ARM64 tags, 2.1 and 2.2. We want to start with 2.2 and go from there.
  • The two preview configs in 2.1 (ARM32 and Alpine) are moving to supported in this release. That's a simple message. I'd like to make ARM64 a 2.2 Preview thing and not confuse the 2.1 release with it.

All that said, "yeah on ARM64!"

@sdmaclea sdmaclea force-pushed the sdmaclea:PR-ARM64-INITIAL branch 7 times, most recently from 1ae9ac0 to 917fbb3 Apr 27, 2018

@sdmaclea
Copy link
Member Author

left a comment

Switched to 2.2 preview1 per request

@@ -0,0 +1,363 @@
{

This comment has been minimized.

Copy link
@sdmaclea

sdmaclea Apr 27, 2018

Author Member

This file is a total guess... It is a copy of the arm32v7 version with a few obvious changes. This probably needs thorough review.

Changes are near the arm64 comments below

"allowOverride": true
},
"imageBuilder.arm64BuildArgs": {
"value": "$(imageBuilder.commonArgs) --path $(PB_imageBuilder_path) --architecture arm64 --skip-test --var VersionFilter=$(PB_imageBuilder_path) --var ArchitectureFilter=arm $(PB_imageBuilder_customArgs) --push --username $(PB_docker_username) --password $(PB_docker_password)",

This comment has been minimized.

Copy link
@sdmaclea

sdmaclea Apr 27, 2018

Author Member

arm64

"enabled": true,
"continueOnError": false,
"alwaysRun": true,
"displayName": "Cleanup ARM64 Docker",

This comment has been minimized.

Copy link
@sdmaclea

sdmaclea Apr 27, 2018

Author Member

arm64

"enabled": true,
"continueOnError": false,
"alwaysRun": false,
"displayName": "Build ARM64 images",

This comment has been minimized.

Copy link
@sdmaclea

sdmaclea Apr 27, 2018

Author Member

arm64

},
"inputs": {
"filename": "docker",
"arguments": "$(docker.runImageBuilder) $(imageBuilder.arm64BuildArgs)",

This comment has been minimized.

Copy link
@sdmaclea

sdmaclea Apr 27, 2018

Author Member

arm64

"allowOverride": true
},
"imageBuilder.arm64BuildArgs": {
"value": "$(imageBuilder.commonArgs) --path $(PB_imageBuilder_path) --architecture arm64 --skip-test --var VersionFilter=$(PB_imageBuilder_path) --var ArchitectureFilter=arm64 $(PB_imageBuilder_customArgs) --push --username $(PB_docker_username) --password $(PB_docker_password)",

This comment has been minimized.

Copy link
@sdmaclea

sdmaclea Apr 27, 2018

Author Member

arm64

}
},
"id": 6214,
"name": "dotnet-docker-linux-arm64v8-images",

This comment has been minimized.

Copy link
@sdmaclea

sdmaclea Apr 27, 2018

Author Member

arm64

@MichaelSimons

This comment has been minimized.

Copy link
Collaborator

commented May 2, 2018

@sdmaclea - We are waiting on machines to run the official builds on. If you would like to checkin just the Dockerfiles without builds at this point I am fine with doing to. Let me know how you want to proceed.

@sdmaclea

This comment has been minimized.

Copy link
Member Author

commented May 2, 2018

@MichaelSimons I am not in any hurry.

@richlander

This comment has been minimized.

Copy link
Member

commented May 30, 2018

FYI: We haven't forgotten about this. We are still deciding on our branch structure for 2.2 and 3.0. My guess is that we'll make ARM64 (no comment on MS support) part of the 3.0 project. master branches should move to 3.0 in June. I wish this had already been done, but it wasn't.

@sdmaclea

This comment has been minimized.

Copy link
Member Author

commented May 31, 2018

@richlander Thanks for the update. I am watching for signs of the CLI building 2.2 or 3.0 so that I can continue testing on Linux-Arm64. There is little point to 2.1 since the ship already sailed.

@richlander

This comment has been minimized.

Copy link
Member

commented May 31, 2018

Great. I sent mail yesterday to get the team to give us a clear story on 2.2 and 3.0 release branches. You are not the only one waiting on clarity ;).

@etherealjoy

This comment has been minimized.

Copy link

commented Jun 10, 2018

@sdmaclea
What about alpine images for arm and arm64.
I have been testing the alpine images for x64 and they are excellent.

@sdmaclea

This comment has been minimized.

Copy link
Member Author

commented Jun 11, 2018

@etherealjoy arm64 and arm alpine images are in progress. @janvorli Is working on creating the builds. The docker images will be able to be created after that.

@sdmaclea sdmaclea force-pushed the sdmaclea:PR-ARM64-INITIAL branch from 917fbb3 to ee5750f Jun 11, 2018

@sdmaclea

This comment has been minimized.

Copy link
Member Author

commented Jun 11, 2018

Rebased and revised to use yml.

manifest: null
matrix: {}
phases:
- phase: Linux_arm32v7

This comment has been minimized.

Copy link
@etherealjoy

etherealjoy Jun 11, 2018

Shouldn't it be arm64? I dont know what it does but seems out of place

This comment has been minimized.

Copy link
@sdmaclea

sdmaclea Jun 11, 2018

Author Member

Done thanks.

@sdmaclea sdmaclea force-pushed the sdmaclea:PR-ARM64-INITIAL branch from ee5750f to de1267e Jun 11, 2018

@richlander

This comment has been minimized.

Copy link
Member

commented Jul 2, 2018

FYI: We are getting closer on this one. We now have 3.0 builds. The builds themselves are not fully correct. I'm hopeful that we'll be able to merge this PR this month.

@MichaelSimons

This comment has been minimized.

Copy link
Collaborator

commented Oct 12, 2018

@sdmaclea - I see your role has changed 😸! Are you interested in working on this anymore or is it alright it I take it over and update the PR?

@sdmaclea

This comment has been minimized.

Copy link
Member Author

commented Oct 12, 2018

@MichaelSimons Thanks. I would appreciate if you took this over.

@MichaelSimons

This comment has been minimized.

Copy link
Collaborator

commented Oct 17, 2018

#760 replaces this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.