-
Notifications
You must be signed in to change notification settings - Fork 122
Address "Swallow Everything" Exceptions #2022
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address "Swallow Everything" Exceptions #2022
Conversation
…c types of Exceptions
… this in a future commit
src/Microsoft.Diagnostics.Monitoring.WebApi/Controllers/DiagController.cs
Show resolved
Hide resolved
src/Tools/dotnet-monitor/Egress/FileSystem/FileSystemEgressProvider.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Diagnostics.Monitoring.WebApi/Controllers/DiagController.cs
Outdated
Show resolved
Hide resolved
|
/backport to release/6.x |
|
Started backporting to release/6.x: https://github.com/dotnet/dotnet-monitor/actions/runs/2584030465 |
|
/backport to release/6.2 |
|
/backport to release/6.1 |
|
Started backporting to release/6.2: https://github.com/dotnet/dotnet-monitor/actions/runs/2584290594 |
|
Started backporting to release/6.1: https://github.com/dotnet/dotnet-monitor/actions/runs/2584291507 |
|
@kkeirstead backporting to release/6.1 failed, the patch most likely resulted in conflicts: $ git am --3way --ignore-whitespace --keep-non-patch changes.patch
Applying: Initial pass at adding logging and/or switching Exceptions to specific types of Exceptions
Applying: Minor tweaks
Applying: Pulled out the logging previously added in DiagController; may revert this in a future commit
Applying: Re-added continue
Applying: Changes based on discussion from PR meeting
.git/rebase-apply/patch:172: trailing whitespace.
.git/rebase-apply/patch:188: trailing whitespace.
.git/rebase-apply/patch:204: trailing whitespace.
warning: 3 lines add whitespace errors.
Using index info to reconstruct a base tree...
M src/Tools/dotnet-monitor/LoggingExtensions.cs
M src/Tools/dotnet-monitor/Strings.Designer.cs
M src/Tools/dotnet-monitor/Strings.resx
Falling back to patching base and 3-way merge...
Auto-merging src/Tools/dotnet-monitor/Strings.resx
CONFLICT (content): Merge conflict in src/Tools/dotnet-monitor/Strings.resx
Auto-merging src/Tools/dotnet-monitor/Strings.Designer.cs
CONFLICT (content): Merge conflict in src/Tools/dotnet-monitor/Strings.Designer.cs
Auto-merging src/Tools/dotnet-monitor/LoggingExtensions.cs
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0005 Changes based on discussion from PR meeting
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128Please backport manually! |
Part of the security review is to address "swallow everything" exceptions; this is an initial pass at adding logging to some of the places where we
catchas well as expanding to specify which exceptions we want to catch. Things to consider:ExceptionIf there are other places where we should make changes that aren't included here, please let me know and I'll add them in.