From 181538ccde854379dd6f15cf3a80262cc9271a5f Mon Sep 17 00:00:00 2001 From: Jose Perez Rodriguez Date: Wed, 1 Nov 2023 21:51:13 +0000 Subject: [PATCH 1/2] [installer] Sync 57efcf1: Merged PR 35017: Update Aspire manifest inserted into installer - Please add description for changes you are making. - If there is an issue related to this PR, please add the reference. Update Aspire manifest inserted into installer Original commit: https://github.com/dotnet/installer/commit/57efcf1350ab087efe97ced8199ab0b494636adf [[ commit created by automation ]] --- README.md | 2 +- prereqs/git-info/AllRepoVersions.props | 2 +- prereqs/git-info/installer.props | 2 +- src/installer/eng/Version.Details.xml | 4 ++-- src/installer/eng/Versions.props | 2 +- src/source-manifest.json | 2 +- 6 files changed, 7 insertions(+), 7 deletions(-) diff --git a/README.md b/README.md index 2aabd298c7e..ac5a6fff1b7 100644 --- a/README.md +++ b/README.md @@ -184,7 +184,7 @@ To enable full offline source-building of the VMR, we have no other choice than - `src/fsharp` *[dotnet/fsharp@f41fe15](https://github.com/dotnet/fsharp/commit/f41fe153f68dd6b20cf4f91de9ea1e55fc09bb20)* - `src/installer` -*[dotnet/installer@9d6e3d7](https://github.com/dotnet/installer/commit/9d6e3d71808815da6f49c7681c35858214d59103)* +*[dotnet/installer@57efcf1](https://github.com/dotnet/installer/commit/57efcf1350ab087efe97ced8199ab0b494636adf)* - `src/msbuild` *[dotnet/msbuild@195e7f5](https://github.com/dotnet/msbuild/commit/195e7f5a3a8e51c37d83cd9e54cb99dc3fc69c22)* - `src/nuget-client` diff --git a/prereqs/git-info/AllRepoVersions.props b/prereqs/git-info/AllRepoVersions.props index 3e7f50a1f5c..9b2a3b8bb47 100644 --- a/prereqs/git-info/AllRepoVersions.props +++ b/prereqs/git-info/AllRepoVersions.props @@ -21,7 +21,7 @@ 8.0.453106 f41fe153f68dd6b20cf4f91de9ea1e55fc09bb20 8.0.100-beta.23523.6 - 9d6e3d71808815da6f49c7681c35858214d59103 + 57efcf1350ab087efe97ced8199ab0b494636adf 8.0.100 195e7f5a3a8e51c37d83cd9e54cb99dc3fc69c22 17.8.3-preview-23519-04 diff --git a/prereqs/git-info/installer.props b/prereqs/git-info/installer.props index 9d6ef6e093e..964864770e1 100644 --- a/prereqs/git-info/installer.props +++ b/prereqs/git-info/installer.props @@ -1,7 +1,7 @@  - 9d6e3d71808815da6f49c7681c35858214d59103 + 57efcf1350ab087efe97ced8199ab0b494636adf 20231101.1 8.0.100 diff --git a/src/installer/eng/Version.Details.xml b/src/installer/eng/Version.Details.xml index 1406f019d9d..a1cebfeed87 100644 --- a/src/installer/eng/Version.Details.xml +++ b/src/installer/eng/Version.Details.xml @@ -172,9 +172,9 @@ https://github.com/dotnet/emsdk 2406616d0e3a31d80b326e27c156955bfa41c791 - + https://dev.azure.com/dnceng/internal/_git/dotnet-aspire - 276cc28b03c11e2850546e604c707e664339fc15 + 4b00c57d7ccf9a4c7e2aef211ab6bd8af3ee2324 diff --git a/src/installer/eng/Versions.props b/src/installer/eng/Versions.props index e2c6743f454..329ab4ece57 100644 --- a/src/installer/eng/Versions.props +++ b/src/installer/eng/Versions.props @@ -238,7 +238,7 @@ 8.0.100 - 8.0.0-preview.1.23531.6 + 8.0.0-preview.1.23551.7 8.0.100-rc.2 8.0.0-rc.2.9373 34.0.0-rc.2.468 diff --git a/src/source-manifest.json b/src/source-manifest.json index a5f1e5d0245..df3db932751 100644 --- a/src/source-manifest.json +++ b/src/source-manifest.json @@ -64,7 +64,7 @@ "packageVersion": "8.0.100", "path": "installer", "remoteUri": "https://github.com/dotnet/installer", - "commitSha": "9d6e3d71808815da6f49c7681c35858214d59103" + "commitSha": "57efcf1350ab087efe97ced8199ab0b494636adf" }, { "packageVersion": "17.8.3-preview-23519-04", From 6640abfc472c5626e740d069e5241a4e0960f6ed Mon Sep 17 00:00:00 2001 From: "dotnet-maestro[bot]" Date: Wed, 1 Nov 2023 21:55:18 +0000 Subject: [PATCH 2/2] =?UTF-8?q?[aspire]=20Sync=20276cc28=20=E2=86=92=204b0?= =?UTF-8?q?0c57=20Diff:=20https://dev.azure.com/dnceng/internal/=5Fgit/dot?= =?UTF-8?q?net-aspire/compare/276cc28b03c11e2850546e604c707e664339fc15..4b?= =?UTF-8?q?00c57d7ccf9a4c7e2aef211ab6bd8af3ee2324?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: https://dev.azure.com/dnceng/internal/_git/dotnet-aspire/commit/276cc28b03c11e2850546e604c707e664339fc15 To: https://dev.azure.com/dnceng/internal/_git/dotnet-aspire/commit/4b00c57d7ccf9a4c7e2aef211ab6bd8af3ee2324 Commits: - Update Redis OpenTelemetry to latest version (#598) (#608) https://dev.azure.com/dnceng/internal/_git/dotnet-aspire/commit/d6dbfde9f5bdd97142b98431f2d39cceb2ca8bf2 - Increase docker command timeout (#591) (#606) https://dev.azure.com/dnceng/internal/_git/dotnet-aspire/commit/4bca4e3d2d4859b2232e910f7893e29188b369b9 - Merged PR 35014: Updating extesions to 8.0.0 https://dev.azure.com/dnceng/internal/_git/dotnet-aspire/commit/4b00c57d7ccf9a4c7e2aef211ab6bd8af3ee2324 [[ commit created by automation ]] --- README.md | 2 +- prereqs/git-info/AllRepoVersions.props | 4 +- prereqs/git-info/aspire.props | 6 +- src/aspire/Directory.Build.props | 5 ++ src/aspire/Directory.Packages.props | 4 +- src/aspire/NuGet.config | 60 ++++++++----------- src/aspire/eng/Version.Details.xml | 6 +- src/aspire/eng/Versions.props | 2 +- src/aspire/eng/pipelines/azure-pipelines.yml | 18 ++++++ src/aspire/eng/pipelines/common-variables.yml | 1 - .../src/Aspire.Hosting/Dcp/DcpHostService.cs | 4 +- src/source-manifest.json | 4 +- 12 files changed, 64 insertions(+), 52 deletions(-) diff --git a/README.md b/README.md index ac5a6fff1b7..26e99d7e9aa 100644 --- a/README.md +++ b/README.md @@ -162,7 +162,7 @@ To enable full offline source-building of the VMR, we have no other choice than - `src/arcade` *[dotnet/arcade@39042b4](https://github.com/dotnet/arcade/commit/39042b4048580366d35a7c1c4f4ce8fc0dbea4b4)* - `src/aspire` -*[_git/dotnet-aspire@276cc28](https://dev.azure.com/dnceng/internal/_git/dotnet-aspire/commit/276cc28b03c11e2850546e604c707e664339fc15)* +*[_git/dotnet-aspire@4b00c57](https://dev.azure.com/dnceng/internal/_git/dotnet-aspire/commit/4b00c57d7ccf9a4c7e2aef211ab6bd8af3ee2324)* - `src/aspnetcore` *[_git/dotnet-aspnetcore@3f1acb5](https://dev.azure.com/dnceng/internal/_git/dotnet-aspnetcore/commit/3f1acb59718cadf111a0a796681e3d3509bb3381)* - `src/aspnetcore/src/submodules/googletest` diff --git a/prereqs/git-info/AllRepoVersions.props b/prereqs/git-info/AllRepoVersions.props index 9b2a3b8bb47..9a923ddf8f5 100644 --- a/prereqs/git-info/AllRepoVersions.props +++ b/prereqs/git-info/AllRepoVersions.props @@ -3,8 +3,8 @@ 39042b4048580366d35a7c1c4f4ce8fc0dbea4b4 8.0.0-beta.23516.4 - 276cc28b03c11e2850546e604c707e664339fc15 - 8.0.0-preview.1.23531.6 + 4b00c57d7ccf9a4c7e2aef211ab6bd8af3ee2324 + 8.0.0-preview.1.23551.7 3f1acb59718cadf111a0a796681e3d3509bb3381 8.0.0-rtm.23531.12 45dd3a73dd5b64b010c4251303b3664bb30df029 diff --git a/prereqs/git-info/aspire.props b/prereqs/git-info/aspire.props index 4eeb7b2b9c3..969b51c1c78 100644 --- a/prereqs/git-info/aspire.props +++ b/prereqs/git-info/aspire.props @@ -1,9 +1,9 @@  - 276cc28b03c11e2850546e604c707e664339fc15 - 20231031.6 - 8.0.0-preview.1.23531.6 + 4b00c57d7ccf9a4c7e2aef211ab6bd8af3ee2324 + 20231101.7 + 8.0.0-preview.1.23551.7 preview.1 false diff --git a/src/aspire/Directory.Build.props b/src/aspire/Directory.Build.props index e93f3bedde5..e83e3b814b7 100644 --- a/src/aspire/Directory.Build.props +++ b/src/aspire/Directory.Build.props @@ -24,6 +24,11 @@ true + + + $(NoWarn);NU1507 + + linux diff --git a/src/aspire/Directory.Packages.props b/src/aspire/Directory.Packages.props index d2d593830a2..e65a5978718 100644 --- a/src/aspire/Directory.Packages.props +++ b/src/aspire/Directory.Packages.props @@ -93,11 +93,11 @@ - + - \ No newline at end of file + diff --git a/src/aspire/NuGet.config b/src/aspire/NuGet.config index 547386c216b..2ccc752369b 100644 --- a/src/aspire/NuGet.config +++ b/src/aspire/NuGet.config @@ -2,6 +2,17 @@ + + + + + + + + + + + @@ -9,40 +20,17 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - + + + + + + + + + + + + + diff --git a/src/aspire/eng/Version.Details.xml b/src/aspire/eng/Version.Details.xml index 4f376a2096d..5b28f3451c6 100644 --- a/src/aspire/eng/Version.Details.xml +++ b/src/aspire/eng/Version.Details.xml @@ -29,9 +29,9 @@ https://github.com/microsoft/usvc-apiserver 7a020a231e5b13608ab3749d30263269ff32984d - - https://github.com/dotnet/extensions - 6602e6a12c012db4246f261c179f74fd612cd0a6 + + https://dev.azure.com/dnceng/internal/_git/dotnet-extensions + 0db4832a73bcd20fe6eaaa01ff64d18e329d438d https://github.com/dotnet/source-build-reference-packages diff --git a/src/aspire/eng/Versions.props b/src/aspire/eng/Versions.props index d8a0cb33be9..9652f1cbad7 100644 --- a/src/aspire/eng/Versions.props +++ b/src/aspire/eng/Versions.props @@ -24,6 +24,6 @@ 8.0.0-beta.23525.4 8.0.0-beta.23525.4 8.0.0-beta.23525.4 - 8.0.0-rtm.23524.3 + 8.0.0 diff --git a/src/aspire/eng/pipelines/azure-pipelines.yml b/src/aspire/eng/pipelines/azure-pipelines.yml index ee144458af7..4bfd9a265cd 100644 --- a/src/aspire/eng/pipelines/azure-pipelines.yml +++ b/src/aspire/eng/pipelines/azure-pipelines.yml @@ -4,12 +4,14 @@ trigger: include: - main - release/* + - internal/release/* pr: branches: include: - main - release/* + - internal/release/* variables: - template: /eng/pipelines/common-variables.yml @@ -73,6 +75,14 @@ stages: fetchDepth: 0 clean: true steps: + - task: PowerShell@2 + displayName: Setup Private Feeds Credentials + condition: eq(variables['Agent.OS'], 'Windows_NT') + inputs: + filePath: $(Build.SourcesDirectory)/eng/common/SetupNugetSources.ps1 + arguments: -ConfigFile $(Build.SourcesDirectory)/NuGet.config -Password $Env:Token + env: + Token: $(dn-bot-dnceng-artifact-feeds-rw) - script: eng\common\cibuild.cmd -configuration $(_BuildConfig) -prepareMachine @@ -112,6 +122,14 @@ stages: - checkout: self clean: true steps: + - task: Bash@3 + displayName: Setup Private Feeds Credentials + inputs: + filePath: $(Build.SourcesDirectory)/eng/common/SetupNugetSources.sh + arguments: $(Build.SourcesDirectory)/NuGet.config $Token + condition: ne(variables['Agent.OS'], 'Windows_NT') + env: + Token: $(dn-bot-dnceng-artifact-feeds-rw) - script: eng/common/cibuild.sh --configuration $(_BuildConfig) --prepareMachine diff --git a/src/aspire/eng/pipelines/common-variables.yml b/src/aspire/eng/pipelines/common-variables.yml index 14c4aca101d..3cb8b96adf2 100644 --- a/src/aspire/eng/pipelines/common-variables.yml +++ b/src/aspire/eng/pipelines/common-variables.yml @@ -20,7 +20,6 @@ variables: # DotNet-Blob-Feed provides: dotnetfeed-storage-access-key-1 # Publish-Build-Assets provides: MaestroAccessToken, BotAccount-dotnet-maestro-bot-PAT # DotNet-HelixApi-Access provides: HelixApiAccessToken - - group: DotNet-Blob-Feed - group: Publish-Build-Assets - group: DotNet-HelixApi-Access - group: SDL_Settings diff --git a/src/aspire/src/Aspire.Hosting/Dcp/DcpHostService.cs b/src/aspire/src/Aspire.Hosting/Dcp/DcpHostService.cs index 99459216a02..27caae5931a 100644 --- a/src/aspire/src/Aspire.Hosting/Dcp/DcpHostService.cs +++ b/src/aspire/src/Aspire.Hosting/Dcp/DcpHostService.cs @@ -190,7 +190,9 @@ private ProcessSpec CreateDcpProcessSpec(Locations locations) return dcpProcessSpec; } - private const int WaitTimeForDockerTestCommandInSeconds = 10; + // Docker goes to into resource saver mode after 5 minutes of not running a container (by default). + // While in this mode, the commands we use for the docker check take quite some time + private const int WaitTimeForDockerTestCommandInSeconds = 25; private void EnsureDockerIfNecessary() { diff --git a/src/source-manifest.json b/src/source-manifest.json index df3db932751..5a51e059645 100644 --- a/src/source-manifest.json +++ b/src/source-manifest.json @@ -7,10 +7,10 @@ "commitSha": "39042b4048580366d35a7c1c4f4ce8fc0dbea4b4" }, { - "packageVersion": "8.0.0-preview.1.23531.6", + "packageVersion": "8.0.0-preview.1.23551.7", "path": "aspire", "remoteUri": "https://dev.azure.com/dnceng/internal/_git/dotnet-aspire", - "commitSha": "276cc28b03c11e2850546e604c707e664339fc15" + "commitSha": "4b00c57d7ccf9a4c7e2aef211ab6bd8af3ee2324" }, { "packageVersion": "8.0.0-rtm.23531.12",