Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up in EntityMaterializerSource #13961

Closed
smitpatel opened this issue Nov 15, 2018 · 2 comments
Closed

Clean up in EntityMaterializerSource #13961

smitpatel opened this issue Nov 15, 2018 · 2 comments
Labels
breaking-change closed-out-of-scope This is not something that will be fixed/implemented and the issue is closed. type-bug

Comments

@smitpatel
Copy link
Member

https://github.com/aspnet/EntityFrameworkCore/blob/4236dfd7f2789782cbba26bf0af15b04dfaf2a0c/src/EFCore/Metadata/Internal/EntityMaterializerSource.cs#L29-L59

We marked old method obsolete to pass in property for value convertor work but now we don't use the property passed in.
@ajcvickers ajcvickers added this to the 3.0.0 milestone Nov 16, 2018
@ajcvickers ajcvickers self-assigned this Mar 8, 2019
ajcvickers added a commit that referenced this issue Mar 10, 2019
@ajcvickers
Remove unused property passed to EntityMaterializerSource.CreateReadV…
678ac58 
…alueExpression

Issue #13961
@ajcvickers ajcvickers mentioned this issue Mar 10, 2019
Merged
ajcvickers added a commit that referenced this issue Mar 10, 2019
@ajcvickers
Remove unused property passed to EntityMaterializerSource.CreateReadV…
91ba971 
…alueExpression

Issue #13961
@ajcvickers ajcvickers added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Mar 10, 2019
ajcvickers added a commit that referenced this issue Mar 11, 2019
@ajcvickers
Remove unused property passed to EntityMaterializerSource.CreateReadV…
0bfdc3b 
…alueExpression

Issue #13961
@smitpatel smitpatel reopened this Mar 27, 2019
@smitpatel
Copy link
Member Author

I actually ended up reverting this in new query pipeline for now. Re-opening this and assigning to me to make sure we have correct change in place for final release.

@smitpatel smitpatel assigned smitpatel and unassigned ajcvickers Mar 27, 2019
@smitpatel smitpatel removed closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. providers-beware labels Mar 27, 2019
@ajcvickers
Copy link
Member

Close; it is needed in the new pipeline, so nothing to do here.

@ajcvickers ajcvickers removed this from the 3.0.0 milestone May 12, 2019
@smitpatel smitpatel removed their assignment Jan 12, 2022
@ajcvickers ajcvickers added the closed-out-of-scope This is not something that will be fixed/implemented and the issue is closed. label Mar 10, 2022
@ajcvickers ajcvickers reopened this Oct 16, 2022
@ajcvickers ajcvickers closed this as not planned Won't fix, can't repro, duplicate, stale Oct 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking-change closed-out-of-scope This is not something that will be fixed/implemented and the issue is closed. type-bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ajcvickers @smitpatel