Note to implementor: This requires updating the logic inside SqliteExpression.Strftime to handle date in addition to strftime:

efcore/src/EFCore.Sqlite.Core/Query/Internal/SqliteExpression.cs

Lines 44 to 55 in e7c0b9d

    
               && rtrimFunction2.Arguments[0] is SqlFunctionExpression strftimeFunction 
        
               && strftimeFunction.Name == "strftime" 
        
               && strftimeFunction.Arguments!.Count > 1) 
        
           { 
        
               // Use its timestring parameter directly in place of ours 
        
               timestring = strftimeFunction.Arguments[1]; 
        
               // Prepend its modifier arguments (if any) to the current call 
        
               modifiers = strftimeFunction.Arguments.Skip(2).Concat(modifiers); 
        
           } 
        
           var finalArguments = new[] { sqlExpressionFactory.Constant(format), timestring }.Concat(modifiers);

We should also think about whether it's possible to get nested date functions.

	&& rtrimFunction2.Arguments[0] is SqlFunctionExpression strftimeFunction
	&& strftimeFunction.Name == "strftime"
	&& strftimeFunction.Arguments!.Count > 1)
	{
	// Use its timestring parameter directly in place of ours
	timestring = strftimeFunction.Arguments[1];

	// Prepend its modifier arguments (if any) to the current call
	modifiers = strftimeFunction.Arguments.Skip(2).Concat(modifiers);
	}

	var finalArguments = new[] { sqlExpressionFactory.Constant(format), timestring }.Concat(modifiers);

Simplify calls to date nested in strftime #25027

Description

rojiopenedon Jun 3, 2021

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

roji
openedon Jun 3, 2021