Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restrict keywords and log levels enabled in EventCountersListener #4109

Merged
merged 1 commit into from
Jun 24, 2023
Merged

Restrict keywords and log levels enabled in EventCountersListener #4109

merged 1 commit into from
Jun 24, 2023

Conversation

xakep139
Copy link
Contributor

@xakep139 xakep139 commented Jun 23, 2023 •
edited by ghost
Loading

This PR fixes #4104

Microsoft Reviewers: Open in CodeFlow

@ghost ghost assigned xakep139 Jun 23, 2023
@xakep139 xakep139 mentioned this pull request Jun 23, 2023
Closed
@xakep139
Copy link
Contributor Author

Test failures seem unrelated - MetricCollectorTests.Dispose and Diagnostics.ResourceMonitoring.Linux

@xakep139 xakep139 enabled auto-merge (squash) June 23, 2023 19:57
@joperezr
Copy link
Member

Test failure is:

  Failed Microsoft.Extensions.Telemetry.Testing.Metering.Test.MetricCollectorTests.Dispose [9 ms]
  Error Message:
   Assert.True() Failure
Expected: True
Actual:   False
  Stack Trace:
     at Microsoft.Extensions.Telemetry.Testing.Metering.Test.MetricCollectorTests.Dispose() in /_/test/Libraries/Microsoft.Extensions.Telemetry.Testing.Tests/Metering/MetricCollectorTests.cs:line 369
--- End of stack trace from previous location ---

Is that a known flaky test @RussKie ?

@xakep139 xakep139 merged commit 14917b8 into main Jun 24, 2023
6 checks passed
@xakep139 xakep139 deleted the xakep139/4104-fix-event-listener branch June 24, 2023 00:02
@ghost ghost added this to the 8.0 Preview7 milestone Jun 24, 2023
@xakep139
Copy link
Contributor Author

Test failure is:

  Failed Microsoft.Extensions.Telemetry.Testing.Metering.Test.MetricCollectorTests.Dispose [9 ms]
  Error Message:
   Assert.True() Failure
Expected: True
Actual:   False
  Stack Trace:
     at Microsoft.Extensions.Telemetry.Testing.Metering.Test.MetricCollectorTests.Dispose() in /_/test/Libraries/Microsoft.Extensions.Telemetry.Testing.Tests/Metering/MetricCollectorTests.cs:line 369
--- End of stack trace from previous location ---

Is that a known flaky test @RussKie ?

It seems that @geeknoid addressed this in #4113

@geeknoid
Copy link
Member

The test failure in MetricCollectorTests is brand new, I checked in a workaround for that.

@ghost ghost locked as resolved and limited conversation to collaborators Jul 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@davidfowl davidfowl davidfowl approved these changes

@geeknoid geeknoid geeknoid approved these changes

Assignees

@xakep139 xakep139

Labels
None yet
Projects
None yet
Milestone
8.0 Preview7
Development

Successfully merging this pull request may close these issues.

EventCountersListener enables all keywords and all log levels on enabled event sources
4 participants
@xakep139 @joperezr @geeknoid @davidfowl