-
Notifications
You must be signed in to change notification settings - Fork 759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update documentation SynchronizationContext in FakeTimeProvider #5665
Update documentation SynchronizationContext in FakeTimeProvider #5665
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Please fix the build though.
src/Libraries/Microsoft.Extensions.TimeProvider.Testing/README.md
Outdated
Show resolved
Hide resolved
@dotnet-policy-service agree company="Microsoft"
@dotnet-policy-service agree company="Microsoft" |
@@ -469,7 +469,7 @@ async Task<int> simulatedPollyRetry() | |||
catch (InvalidOperationException) | |||
{ | |||
// ConfigureAwait(true) is required to ensure that tasks continue on the captured context |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment doesn't match the code now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in #5683
Solves #5500
Microsoft Reviewers: Open in CodeFlow