For AI integration tests, use config including user secrets #5706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… source, not just env vars
|
🎉 Good job! The coverage increased 🎉
Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=882370&view=codecoverage-tab |
stephentoub
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was getting tired of having to remember to set environment variables and restart VS whenever I wanted to run the integration tests. We were also a bit out of line with our recommendations in using
GetEnvironmentVariabledirectly instead of going through theIConfigurationabstraction which allows for multiple configuration sources.With this change, you can set your config just once using
dotnet user-secretsand it will be stored in your user profile in a way that's scoped to this repo. Instructions added to readme file.Alternatively you can continue using environment variables (though the names have changed to match .NET config naming conventions).