Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update otel chat client / embedding generator for 1.29 draft of the spec #5712

Merged
merged 6 commits into from
Dec 4, 2024
Merged

Update otel chat client / embedding generator for 1.29 draft of the spec #5712

merged 6 commits into from
Dec 4, 2024

Conversation

stephentoub
Copy link
Member

@stephentoub stephentoub commented Dec 2, 2024 •
edited by dotnet-policy-service bot
Loading

Also address feedback to include additional properties as tags.
Closes #5583

Microsoft Reviewers: Open in CodeFlow

@stephentoub stephentoub requested a review from a team as a code owner December 2, 2024 15:11
@stephentoub
Update otel chat client / embedding generator for 1.29
d2efdba 
Also address feedback to include additional properties as tags.
@dotnet dotnet deleted a comment from dotnet-comment-bot Dec 3, 2024
@dotnet dotnet deleted a comment from dotnet-comment-bot Dec 3, 2024
@dotnet-comment-bot
Copy link
Collaborator

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

Project Expected Actual
Microsoft.Extensions.Diagnostics.Probes 70 76
Microsoft.Extensions.AI 83 88
Microsoft.Extensions.Caching.Hybrid 75 86

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=884574&view=codecoverage-tab

@dotnet-comment-bot
Copy link
Collaborator

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

Project Expected Actual
Microsoft.Extensions.Caching.Hybrid 75 77
Microsoft.Extensions.Diagnostics.Probes 70 76

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=884588&view=codecoverage-tab

@dotnet-comment-bot
Copy link
Collaborator

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

Project Expected Actual
Microsoft.Extensions.Diagnostics.Probes 70 76
Microsoft.Extensions.Caching.Hybrid 75 77

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=885181&view=codecoverage-tab

@dotnet-comment-bot
Copy link
Collaborator

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

Project Expected Actual
Microsoft.Extensions.Diagnostics.Probes 70 76
Microsoft.Extensions.Caching.Hybrid 75 85
Microsoft.Extensions.AI.Abstractions 83 84

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=886031&view=codecoverage-tab

@stephentoub stephentoub enabled auto-merge (squash) December 4, 2024 15:01
@dotnet-comment-bot
Copy link
Collaborator

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

Project Expected Actual
Microsoft.Extensions.Diagnostics.Probes 70 76
Microsoft.Extensions.Caching.Hybrid 75 86

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=886211&view=codecoverage-tab

@stephentoub stephentoub merged commit a23a7a9 into dotnet:main Dec 4, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SteveSandersonMS SteveSandersonMS SteveSandersonMS approved these changes

Assignees

@stephentoub stephentoub

Labels
area-AI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Microsoft.Extensions.AI] Add EndUserId as tag to span/traces/metrics
3 participants
@stephentoub @dotnet-comment-bot @SteveSandersonMS