Fix streaming function calling #5718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephentoub
reviewed
Dec 3, 2024
src/Libraries/Microsoft.Extensions.AI/ChatCompletion/FunctionInvokingChatClient.cs
Show resolved
Hide resolved
|
🎉 Good job! The coverage increased 🎉
Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=885239&view=codecoverage-tab |
stephentoub
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was part of the
FunctionInvokingChatClientimplementation that I couldn't understand, and after investigation, I think it's a bug.Our tests don't cover any cases where streaming returns multiple updates that contain function calls. I think that's a legitimate scenario, but I'm not sure that it can be modelled by the
InvokeAndAssertStreamingAsynchelper we use in those tests, because it treats each "plan" entry as the end of a response.I've added a test showing what I think is this legitimate response format with multiple updates that have function calls. Without the fix in
FunctionInvokingChatClient, it only removes one of the two FCCs from the result (and so the other one is both added to history and returned, which the method's XML docs say should not happen). The fix is completely trivial.Microsoft Reviewers: Open in CodeFlow