Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to filter diagnostics by id #1007

Merged
merged 3 commits into from Feb 26, 2021

Conversation

@JoeRobich
Copy link
Member

@JoeRobich JoeRobich commented Feb 26, 2021

Resolves #1006

@@ -49,6 +50,10 @@ internal static RootCommand CreateCommandLineOptions()
{
Argument = new Argument<string?>("severity") { Arity = ArgumentArity.ZeroOrOne }.FromAmong(SeverityLevels)
},
new Option(new[] { "--diagnostics" }, Resources.A_space_separated_list_of_diagnostic_ids_to_use_as_a_filter_when_fixing_code_style_or_3rd_party_issues)
{
Argument = new Argument<string[]>(() => Array.Empty<string>())
Copy link
Member

@jmarolf jmarolf Feb 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like it if we could provide a helpful message if this option is provide and we are not in a --fix-stlye or --fix-analyzers mode

@JoeRobich JoeRobich force-pushed the add-diagnostics-filter branch from 4b40a17 to ed79a06 Feb 26, 2021
@JoeRobich JoeRobich merged commit d4bedaf into dotnet:master Feb 26, 2021
18 checks passed
@JoeRobich JoeRobich deleted the add-diagnostics-filter branch Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants