Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run CodeStyle formatter before removing unnecessary imports #1071

Merged
merged 2 commits into from Mar 31, 2021

Conversation

@JoeRobich
Copy link
Member

@JoeRobich JoeRobich commented Mar 31, 2021

Resolves #1069

As pointed out, converting declarations to use var when fixing code style issues potentially creates unused imports.

Copy link
Member

@jmarolf jmarolf left a comment

You read my mind, This was literally my thoughts. as long as we run this last should be correct (for most of the cases)

@JoeRobich
Copy link
Member Author

@JoeRobich JoeRobich commented Mar 31, 2021

as long as we run this last

Hmm. We can make this truly run last. Didn't think about how 3rd party analyzers might create this same situation.

src/CodeFormatter.cs Outdated Show resolved Hide resolved
@JoeRobich JoeRobich merged commit 90b477f into main Mar 31, 2021
18 checks passed
@JoeRobich JoeRobich added this to the 5.1 milestone Mar 31, 2021
@JoeRobich JoeRobich deleted the reorder-imports-formatter branch Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants