New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update of EF description #128

Merged
merged 1 commit into from Jan 9, 2019

Conversation

Projects
None yet
3 participants
@ErikEJ
Copy link
Contributor

ErikEJ commented Jan 4, 2019

@ErikEJ ErikEJ referenced this pull request Jan 4, 2019

Closed

Out of date info #14282

@divega
Copy link
Member

divega left a comment

Hi @ErikEJ. At first glance, I prefer to either split it into two separate projects, "Entity Framework Core" and "Entity Framework 6", or keep it organized the way it already is: single "Entity Framework" projects with a subsection that explains that there are two versions.

But feel free to convince me that this is a good change. I may be missing the point 😄

Show resolved Hide resolved projects/entity-framework.md
Show resolved Hide resolved projects/entity-framework.md Outdated
Show resolved Hide resolved projects/entity-framework.md Outdated
Show resolved Hide resolved projects/entity-framework.md Outdated
Show resolved Hide resolved projects/entity-framework.md Outdated
@jongalloway

This comment has been minimized.

Copy link
Contributor

jongalloway commented Jan 5, 2019

Not sure from the conversation if this is ready to merge - @divega, you still have open questions, correct?

@divega

This comment has been minimized.

Copy link
Member

divega commented Jan 5, 2019

@jongalloway correct.

@ErikEJ

This comment has been minimized.

Copy link
Contributor

ErikEJ commented Jan 5, 2019

@divega This PR got mixed up with the previous one!

@ErikEJ ErikEJ force-pushed the ErikEJ:efupdate branch from accacab to c254bab Jan 5, 2019

@ErikEJ

This comment has been minimized.

Copy link
Contributor

ErikEJ commented Jan 5, 2019

Updated!

@divega

divega approved these changes Jan 5, 2019

Copy link
Member

divega left a comment

Thank you @ErikEJ. Looks good!

@divega

This comment has been minimized.

Copy link
Member

divega commented Jan 9, 2019

@jongalloway from my side this looks ready.

@jongalloway jongalloway merged commit 58dccdb into dotnet:master Jan 9, 2019

1 check passed

license/cla All CLA requirements met.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment