Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed error message for Seq.take when count exceeds sequence length #10525

Merged
merged 1 commit into from Nov 24, 2020
Merged

Fixed error message for Seq.take when count exceeds sequence length #10525

merged 1 commit into from Nov 24, 2020

Conversation

TheJayMann
Copy link
Contributor

#9490

  • Update error message placeholders to format error message correctly
  • Converted count up to count down to show properly how many more elements were requested but not fulfilled

#9490 
- Update error message placeholders to format error message correctly
- Converted count up to count down to show properly how many more elements were requested but not fulfilled
@cartermp cartermp linked an issue Nov 22, 2020 that may be closed by this pull request
Copy link
Contributor

@cartermp cartermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@cartermp cartermp merged commit fd688c7 into dotnet:main Nov 24, 2020
@voroninp
Copy link
Contributor

voroninp commented Dec 3, 2020

@cartermp So, what do you think about extending error message?

@cartermp
Copy link
Contributor

cartermp commented Dec 4, 2020

I think we'd certainly take a look at a PR that continued to improve the message and decide if it makes sense.

@cartermp cartermp modified the milestone: 16.9 Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Strange error in Seq.take on count exceeding length
3 participants