Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #11143 - FSharp.Core 5.0.1 should not have FSharp.Core.xml in contentFiles #11160

Merged
merged 1 commit into from Mar 2, 2021

Conversation

KevinRansom
Copy link
Member

@KevinRansom KevinRansom commented Feb 27, 2021

Fixes: #11143 - FSharp.Core 5.0.1 should not have FSharp.Core.xml in contentFiles

The FSharp.Core nuget package has been updated to carry FSharp.Core.xml as content, which enables the build to pick it up for tools that want to show help messages for API's.

Content files from nuget packages are automatically referenced which is somewhat unfortunate for FSharp.Core, where the overwhelming majority of apps will not want to redistribute that file.

This change makes including FSharp.Core.xml in build output opt-in.

To ensure that FSharp.Core.xml is included in the distributed app, add this to a PropertyGroup in the build project:

    <FSharpCoreIncludeDocFileInOutput>true</FSharpCoreIncludeDocFileInOutput>

image


image

TIHan
TIHan approved these changes Mar 2, 2021
brettfo
brettfo approved these changes Mar 2, 2021
@cartermp cartermp merged commit 4467ee3 into dotnet:main Mar 2, 2021
14 checks passed
@KevinRansom KevinRansom deleted the Fix11143 branch Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants