Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I suppose this is a form of bike-shedding, but the source in our tree doesn't match our binary names, which irks me every time I come to it. We refer to
and so on but our source is always
Microsoft.FSharp.Compiler
.Among other things this means you see a wall of text whenever you look at the
open
declarations at the head of the file on the F# compiler. Personally I think the compiler code looks simpler and more approachable with the shorter, plainer names - everyone knows Microsoft contribute heavily to F# and package it, we don't need to tell them 1700 times in the compiler code.So I suggest we rename
Microsoft.FSharp.Compiler
-->FSharp.Compiler
in our source.This only affects the internal compiler code and the API of FSharp.Compiler.Service.dll
The one exception is
FSharp.Compiler.Interactive.Settings
, whereopen Microsoft.FSharp.Compiler.Interactive.Settings
can be opened from existing F# scripts. I've added 10 lines to make sure still worksThis doesn't affect
FSharp.Core
, which must remain binary compatible. (As background: Back in F# 3.1 we did a while lot of work to allow "open FSharp.Core" to be used instead of "open Microsoft.FSharp.Core". This is in line with that but we can simply rename the source)This doesn't affect the name of the
Microsoft.FSharp.Compiler
nuget package which is built as part of Microsoft's the distribution of F# in the .NET SDK.This doesn't affect the Visual F# bits.
This also does
Microsoft.FSharp.Build
-->FSharp.Build
- again the DLL name is not changed, and theUsingTasks
references don't refer to namespaces