Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable language preview option for fsi in the ide #8443

Merged
merged 1 commit into from Feb 3, 2020

Conversation

@KevinRansom
Copy link
Member

KevinRansom commented Feb 1, 2020

Provide an option to enable preview mode in fsi on visual studio.

image

@KevinRansom KevinRansom requested review from brettfo, TIHan and cartermp Feb 1, 2020
@Happypig375 Happypig375 mentioned this pull request Feb 1, 2020
5 of 5 tasks complete
@brettfo
brettfo approved these changes Feb 1, 2020
[| "--langversion:preview" |]
else
[||]
let otherFlags = defaultArg otherFlags extraFlags

This comment has been minimized.

Copy link
@brettfo

brettfo Feb 1, 2020

Member

Should otherFlags not be the combination of otherFlags and preview?

@KevinRansom KevinRansom merged commit 3b9f82b into dotnet:master Feb 3, 2020
14 checks passed
14 checks passed
WIP Ready for review
Details
fsharp-ci Build #20200201.1 succeeded
Details
fsharp-ci (Build Linux) Build Linux succeeded
Details
fsharp-ci (Build Linux_FCS) Build Linux_FCS succeeded
Details
fsharp-ci (Build MacOS) Build MacOS succeeded
Details
fsharp-ci (Build SourceBuild_Linux) Build SourceBuild_Linux succeeded
Details
fsharp-ci (Build SourceBuild_Windows) Build SourceBuild_Windows succeeded
Details
fsharp-ci (Build UpToDate_Windows) Build UpToDate_Windows succeeded
Details
fsharp-ci (Build Windows coreclr_release) Build Windows coreclr_release succeeded
Details
fsharp-ci (Build Windows desktop_release) Build Windows desktop_release succeeded
Details
fsharp-ci (Build Windows fsharpqa_release) Build Windows fsharpqa_release succeeded
Details
fsharp-ci (Build Windows vs_release) Build Windows vs_release succeeded
Details
fsharp-ci (Build Windows_FCS) Build Windows_FCS succeeded
Details
license/cla All CLA requirements met.
Details
KevinRansom added a commit that referenced this pull request Feb 5, 2020
* Enable language preview option for fsi in the ide (#8443)

* Reattach comment (#8445)

Co-authored-by: Kevin Ransom (msft) <codecutter.fsharp@hotmail.com>
@KevinRansom KevinRansom deleted the KevinRansom:enablepreviewfsi branch Feb 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.