Skip to content

Commit

Permalink
Remove logging of error for no poison leaks (#17159)
Browse files Browse the repository at this point in the history
  • Loading branch information
mthalman committed Aug 9, 2023
1 parent f5ad81b commit 7ebbb2d
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 16 deletions.
Expand Up @@ -160,11 +160,6 @@ public override bool Execute()
{
Log.LogWarning($"{poisons.Count()} marked files leaked to output. See complete report '{PoisonReportOutputFilePath}' for details.");
}
else
{
Log.LogError($"No leaked files found in output. Either something is broken or it is the future and we have fixed all leaks - please verify and remove this error if so (and default {nameof(FailOnPoisonFound)} to true).");
return false;
}

return !Log.HasLoggedErrors;
}
Expand Down
@@ -1,11 +1 @@
<PrebuiltLeakReport>
<File Path="dotnet-format.x.y.z/tools/netx.y/any/Microsoft.CodeAnalysis.AnalyzerUtilities.dll">
<Type>AssemblyAttribute</Type>
</File>
<File Path="dotnet-sdk-x.y.z-banana-rid.tar/sdk/x.y.z/DotnetTools/dotnet-format/Microsoft.CodeAnalysis.AnalyzerUtilities.dll">
<Type>AssemblyAttribute</Type>
</File>
<File Path="dotnet-sdk-x.y.z-banana-rid.tar/sdk/x.y.z/DotnetTools/dotnet-watch/x.y.z/tools/netx.y/any/Microsoft.CodeAnalysis.AnalyzerUtilities.dll">
<Type>AssemblyAttribute</Type>
</File>
</PrebuiltLeakReport>
<PrebuiltLeakReport />

0 comments on commit 7ebbb2d

Please sign in to comment.