From 4cb18cbda6d521833a318a3d92f00685396eaf77 Mon Sep 17 00:00:00 2001 From: Laurent Ellerbach Date: Tue, 25 Aug 2020 16:11:42 +0300 Subject: [PATCH 1/5] Fixing DHT issues, adding docuementation as well --- src/devices/Dhtxx/Devices/Dht21.cs | 2 +- src/devices/Dhtxx/Devices/Dht22.cs | 2 +- src/devices/Dhtxx/DhtBase.cs | 8 +- src/devices/Dhtxx/README.md | 96 ++++++++++++-- src/devices/Dhtxx/samples/DhtSensor.sample.cs | 117 ++++++++++++++++-- src/devices/Dhtxx/samples/README.md | 49 ++++++-- 6 files changed, 239 insertions(+), 35 deletions(-) diff --git a/src/devices/Dhtxx/Devices/Dht21.cs b/src/devices/Dhtxx/Devices/Dht21.cs index cfe967c4f6..00d213d37c 100644 --- a/src/devices/Dhtxx/Devices/Dht21.cs +++ b/src/devices/Dhtxx/Devices/Dht21.cs @@ -31,7 +31,7 @@ internal override Ratio GetHumidity(byte[] readBuff) internal override Temperature GetTemperature(byte[] readBuff) { - var temp = (readBuff[2] & 0x7F) + readBuff[3] * 0.1; + var temp = ((readBuff[2] & 0x7F) << 8 | readBuff[3]) * 0.1; // if MSB = 1 we have negative temperature temp = ((readBuff[2] & 0x80) == 0 ? temp : -temp); diff --git a/src/devices/Dhtxx/Devices/Dht22.cs b/src/devices/Dhtxx/Devices/Dht22.cs index 598aec6d19..7b4efd06a6 100644 --- a/src/devices/Dhtxx/Devices/Dht22.cs +++ b/src/devices/Dhtxx/Devices/Dht22.cs @@ -31,7 +31,7 @@ internal override Ratio GetHumidity(byte[] readBuff) internal override Temperature GetTemperature(byte[] readBuff) { - var temp = ((readBuff[2] & 0x7F) * 256 + readBuff[3]) * 0.1; + var temp = ((readBuff[2] & 0x7F) << 8 | readBuff[3]) * 0.1; // if MSB = 1 we have negative temperature temp = ((readBuff[2] & 0x80) == 0 ? temp : -temp); diff --git a/src/devices/Dhtxx/DhtBase.cs b/src/devices/Dhtxx/DhtBase.cs index d682de2eb9..007bc8e6d6 100644 --- a/src/devices/Dhtxx/DhtBase.cs +++ b/src/devices/Dhtxx/DhtBase.cs @@ -58,7 +58,7 @@ public abstract class DhtBase : IDisposable /// Get the last read temperature /// /// - /// If last read was not successfull, it returns default(Temperature) + /// If last read was not successful, it returns default(Temperature) /// public virtual Temperature Temperature { @@ -73,7 +73,7 @@ public virtual Temperature Temperature /// Get the last read of relative humidity in percentage /// /// - /// If last read was not successfull, it returns default(Ratio) + /// If last read was not successful, it returns default(Ratio) /// public virtual Ratio Humidity { @@ -281,6 +281,10 @@ public void Dispose() { _controller?.Dispose(); } + else + { + _controller.ClosePin(_pin); + } _i2cDevice?.Dispose(); } diff --git a/src/devices/Dhtxx/README.md b/src/devices/Dhtxx/README.md index a7c282f60c..589640213a 100644 --- a/src/devices/Dhtxx/README.md +++ b/src/devices/Dhtxx/README.md @@ -7,8 +7,8 @@ The DHT temperature and humidity sensors are very popular. This projects support | | DHT10 | DHT11 | DHT12 | DHT21 | DHT22 | | :------: | :------: | :------: | :------: | :------: | :------: | | Image | | | | | | -| Temperature Range | -40 ~ 80 ℃ | -20 ~ 60 ℃ | -20 ~ 60 ℃ | -40 ~ 80 ℃ | -40 ~ 80 ℃ | -| Humidity Range | 0 ~ 99.9 % | 5 ~ 95 % | 20 ~ 95 % | 0 ~ 99.9 % | 0 ~ 99.9 % | +| Temperature Range | -40 ~ 80 ℃ | 0 ~ 60 ℃ | -20 ~ 60 ℃ | -40 ~ 80 ℃ | -40 ~ 80 ℃ | +| Humidity Range | 0 ~ 99.9 % | 2 ~ 95 % | 20 ~ 95 % | 0 ~ 99.9 % | 0 ~ 99.9 % | | Temperature Accuracy | ±0.5 ℃ | ±2 ℃ | ±0.5 ℃ | ±0.5 ℃ | ±0.5 ℃ | | Humidity Accuracy | ±3 % | ±5 % | ±4 % | ±3 % | ±2 % | | Protocol | I2C | 1-Wire | I2C, 1-Wire | 1-Wire | 1-Wire | @@ -21,13 +21,29 @@ The DHT temperature and humidity sensors are very popular. This projects support // GPIO Pin using (Dht11 dht = new Dht11(26)) { - Temperature temperature = dht.Temperature; - double humidity = dht.Humidity; + var temperature = dht.Temperature; + var humidity = dht.Humidity; + // You can only display temperature and humidity if the read is successful otherwise, this will raise an exception as + // both temperature and humidity are NAN + if (dht.IsLastReadSuccessful) + { + Console.WriteLine($"Temperature: {temperature.DegreesCelsius} \u00B0C, Humidity: {humidity.Percent} %"); + + // WeatherHelper supports more calculations, such as saturated vapor pressure, actual vapor pressure and absolute humidity. + Console.WriteLine( + $"Heat index: {WeatherHelper.CalculateHeatIndex(temperature, humidity).Celsius:0.#}\u00B0C"); + Console.WriteLine( + $"Dew point: {WeatherHelper.CalculateDewPoint(temperature, humidity).Celsius:0.#}\u00B0C"); + } + else + { + Console.WriteLine("Error reading DHT sensor"); + } } ``` -**Note:** _Specifically on the RPi with the DHT22, 1-Wire works using Raspian but not with IoT-Core. The device has to switch the 1-wire pin between input and output and vice versa. It seems that Windows IoT-Core OS can't switch the pin direction quick enough. There have been suggestions for using two pins; one for input and one for output. This solution has not been implemented here, but these are some handy links that may help setting that up:_ +**Note:** _Specifically on the RPi with the DHT22, 1-Wire works using Raspian but not with Windows 10 IoT Core. The device has to switch the 1-wire pin between input and output and vice versa. It seems that Windows IoT Core OS can't switch the pin direction quick enough. There have been suggestions for using two pins; one for input and one for output. This solution has not been implemented here, but these are some handy links that may help setting that up:_ - https://github.com/ms-iot/samples/tree/develop/GpioOneWire -- And on Hackster.io (https://www.hackster.io/porrey/go-native-c-with-the-dht22-a8e8eb +- And on Hackster.io: https://www.hackster.io/porrey/go-native-c-with-the-dht22-a8e8eb ### I2C Protocol @@ -41,18 +57,74 @@ using (Dht12 dht = new Dht12(device)) { var tempValue = dht.Temperature; var humValue = dht.Humidity; + if (dht.IsLastReadSuccessful) + { + Console.WriteLine($"Temperature: {tempValue.Celsius:0.#}\u00B0C"); + Console.WriteLine($"Relative humidity: {humValue:0.#}%"); + + // WeatherHelper supports more calculations, such as saturated vapor pressure, actual vapor pressure and absolute humidity. + Console.WriteLine( + $"Heat index: {WeatherHelper.CalculateHeatIndex(tempValue, humValue).Celsius:0.#}\u00B0C"); + Console.WriteLine( + $"Dew point: {WeatherHelper.CalculateDewPoint(tempValue, humValue).Celsius:0.#}\u00B0C"); +} } + else + { + Console.WriteLine("Error reading DHT sensor"); + } +} +``` + +## Reading frequency and quality measurement + +In the case of I2C or GPIO, any type of DHT needs a bit of time between 2 readings. DHT22 documentation refer to a sensing period of 2 seconds and a collecting period higher than 1.7 seconds. +Measuring with higher frequency won't give you more accurate numbers. As you can see from the specifications, the accuracy depends on the sensor type, it goes from ±2 ℃ for the DHT11 to ±0.5 ℃ for the others. +Even if the parity check can come clear, we do recommend to check that the data are in a normal range. For example of humidity is higher than 100%, then it means that measurement is wrong. +This check has not been done in the binding itself, so you may consider adding a check on your application side. + +The DHT sensors are very sensitive, avoid too long cables, electromagnetic perturbations and compile the code as release not debug to increase the quality of measurement. + +## FAQ + +**I always get wrong measurements, what's happening?** + +Please check that the sensor is plugged correctly, make sure you are using the correct pin. + +Please check you are using the correct sensor, only DHT10 and DHT12 supports I2C. All others support only GPIO with 1 wire protocol. DHT12 supports both. + +**The data I measure are not correct, humidity seems ok but temperature is always weird, what's the problem?** + +Please check you are using the correct sensor. Refer to the top part of this page to check which sensor you have. Using a DHT11 instead of a DHT22 will give you a wrong temperature. +**I am trying to get a temperature and humidity 5 times per seconds but I mainly get wrong measurements, why?** + +This is absolutely normal, you should check the measurements once every 2 seconds approximately. Don't try to get more measures than once every 2 seconds. + +**When reading the temperature and humidity and trying to write the data in the console, I get an exception, why?** + +You need to check first if the measurement has been successful. If the measurement hasn't been successful, the default values will be NaN and so you won't be able to convert the temperature or humidity and you'll get an exception. This is the correct way of first reading the sensor and then checking the reading was correct and finally using the temperature and humidity data: + +```csharp +var tempValue = dht.Temperature; +var humValue = dht.Humidity; +if (dht.IsLastReadSuccessful) +{ Console.WriteLine($"Temperature: {tempValue.Celsius:0.#}\u00B0C"); Console.WriteLine($"Relative humidity: {humValue:0.#}%"); - - // WeatherHelper supports more calculations, such as saturated vapor pressure, actual vapor pressure and absolute humidity. - Console.WriteLine( - $"Heat index: {WeatherHelper.CalculateHeatIndex(tempValue, humValue).Celsius:0.#}\u00B0C"); - Console.WriteLine( - $"Dew point: {WeatherHelper.CalculateDewPoint(tempValue, humValue).Celsius:0.#}\u00B0C"); } ``` +**I have a Raspberry Pi 4 and I get an exception when creating the DHT sensor** + +See this [issue 1145](https://github.com/dotnet/iot/issues/1145). We're actively trying to fix it automatically. You will have to force using either the Raspberry Pi 3 driver, either the LibGpiodDriver. This is how you can force using a specific drive, in this case the Raspberry Pi 3 one which will work: + +```csharp +GpioDriver driver = new RaspberryPi3Driver(); +var controller = new GpioController(PinNumberingScheme.Logical, driver); +// This uses pin 4 in the logical schema so pin 7 in the physical schema +var dht = new Dht11(4, gpioController: controller); +``` + ## References * **DHT10** [datasheet (Currently only Chinese)](http://www.aosong.com/userfiles/files/media/DHT10%E8%A7%84%E6%A0%BC%E4%B9%A6.pdf) diff --git a/src/devices/Dhtxx/samples/DhtSensor.sample.cs b/src/devices/Dhtxx/samples/DhtSensor.sample.cs index a2de9f5502..554909682f 100644 --- a/src/devices/Dhtxx/samples/DhtSensor.sample.cs +++ b/src/devices/Dhtxx/samples/DhtSensor.sample.cs @@ -15,26 +15,125 @@ internal class Program public static void Main(string[] args) { Console.WriteLine("Hello DHT!"); + Console.WriteLine("Select the DHT sensor you want to use:"); + Console.WriteLine(" 1. DHT10 on I2C"); + Console.WriteLine(" 2. DHT11 on GPIO"); + Console.WriteLine(" 3. DHT12 on GPIO"); + Console.WriteLine(" 4. DHT21 on GPIO"); + Console.WriteLine(" 5. DHT22 on GPIO"); + var choice = Console.ReadKey(); + Console.WriteLine(); + if (choice.KeyChar == '1') + { + Console.WriteLine("Press any key to stop the reading"); + Dht10II2c(); + return; + } + + Console.WriteLine("Which pin do you want to use in the logical pin schema?"); + var pinChoise = Console.ReadLine(); + int pin; + try + { + pin = Convert.ToInt32(pinChoise); + } + catch (Exception ex) when (ex is FormatException || ex is OverflowException) + { + Console.WriteLine("Can't convert pin number."); + return; + } + + Console.WriteLine("Press any key to stop the reading"); + + switch (choice.KeyChar) + { + case '2': + Console.WriteLine($"Reading temperature and humidity on DHT11, pin {pin}"); + using (var dht11 = new Dht11(pin)) + { + Dht(dht11); + } + + break; + case '3': + Console.WriteLine($"Reading temperature and humidity on DHT12, pin {pin}"); + using (var dht12 = new Dht12(pin)) + { + Dht(dht12); + } + + break; + case '4': + Console.WriteLine($"Reading temperature and humidity on DHT21, pin {pin}"); + using (var dht21 = new Dht21(pin)) + { + Dht(dht21); + } + + break; + case '5': + Console.WriteLine($"Reading temperature and humidity on DHT22, pin {pin}"); + using (var dht22 = new Dht22(pin)) + { + Dht(dht22); + } + + break; + default: + Console.WriteLine("Please select one of the option."); + break; + } + } + + private static void Dht(DhtBase dht) + { + while (!Console.KeyAvailable) + { + var temp = dht.Temperature; + var hum = dht.Humidity; + // You can only display temperature and humidity if the read is successful otherwise, this will raise an exception as + // both temperature and humidity are NAN + if (dht.IsLastReadSuccessful) + { + Console.WriteLine($"Temperature: {temp.DegreesCelsius}\u00B0C, Relative humidity: {hum.Percent}%"); + } + else + { + Console.WriteLine("Error reading DHT sensor"); + } + // You must wait some time before trying to read the next value + Thread.Sleep(2000); + } + } + + private static void Dht10II2c() + { // Init DHT10 through I2C I2cConnectionSettings settings = new I2cConnectionSettings(1, Dht10.DefaultI2cAddress); I2cDevice device = I2cDevice.Create(settings); using (Dht10 dht = new Dht10(device)) { - while (true) + while (!Console.KeyAvailable) { var tempValue = dht.Temperature; var humValue = dht.Humidity; + if (dht.IsLastReadSuccessful) + { + Console.WriteLine($"Temperature: {tempValue.DegreesCelsius:0.#}\u00B0C"); + Console.WriteLine($"Relative humidity: {humValue:0.#}%"); - Console.WriteLine($"Temperature: {tempValue.DegreesCelsius:0.#}\u00B0C"); - Console.WriteLine($"Relative humidity: {humValue:0.#}%"); - - // WeatherHelper supports more calculations, such as saturated vapor pressure, actual vapor pressure and absolute humidity. - Console.WriteLine( - $"Heat index: {WeatherHelper.CalculateHeatIndex(tempValue, humValue).DegreesCelsius:0.#}\u00B0C"); - Console.WriteLine( - $"Dew point: {WeatherHelper.CalculateDewPoint(tempValue, humValue).DegreesCelsius:0.#}\u00B0C"); + // WeatherHelper supports more calculations, such as saturated vapor pressure, actual vapor pressure and absolute humidity. + Console.WriteLine( + $"Heat index: {WeatherHelper.CalculateHeatIndex(tempValue, humValue).DegreesCelsius:0.#}\u00B0C"); + Console.WriteLine( + $"Dew point: {WeatherHelper.CalculateDewPoint(tempValue, humValue).DegreesCelsius:0.#}\u00B0C"); + } + else + { + Console.WriteLine("Error reading DHT sensor"); + } Thread.Sleep(2000); } diff --git a/src/devices/Dhtxx/samples/README.md b/src/devices/Dhtxx/samples/README.md index 3d18d360ed..59bf4a6780 100644 --- a/src/devices/Dhtxx/samples/README.md +++ b/src/devices/Dhtxx/samples/README.md @@ -27,27 +27,56 @@ Some sensors are already sold with the 10K resistor. Connect the GPIO26 to the * ## Code ```csharp +// GPIO Pin using (Dht11 dht = new Dht11(26)) { - while (true) + var temperature = dht.Temperature; + var humidity = dht.Humidity; + // You can only display temperature and humidity if the read is successful otherwise, this will raise an exception as + // both temperature and humidity are NAN + if (dht.IsLastReadSuccessful) { - var tempValue = dht.Temperature; - var humValue = dht.Humidity; - - Console.WriteLine($"Temperature: {tempValue.Celsius:0.#}\u00B0C"); - Console.WriteLine($"Relative humidity: {humValue:0.#}%"); + Console.WriteLine($"Temperature: {temperature.DegreesCelsius} \u00B0C, Humidity: {humidity.Percent} %"); // WeatherHelper supports more calculations, such as saturated vapor pressure, actual vapor pressure and absolute humidity. Console.WriteLine( - $"Heat index: {WeatherHelper.CalculateHeatIndex(tempValue, humValue).Celsius:0.#}\u00B0C"); + $"Heat index: {WeatherHelper.CalculateHeatIndex(temperature, humidity).Celsius:0.#}\u00B0C"); Console.WriteLine( - $"Dew point: {WeatherHelper.CalculateDewPoint(tempValue, humValue).Celsius:0.#}\u00B0C"); - - Thread.Sleep(1000); + $"Dew point: {WeatherHelper.CalculateDewPoint(temperature, humidity).Celsius:0.#}\u00B0C"); + } + else + { + Console.WriteLine("Error reading DHT sensor"); } } ``` +## Sample application navigation + +This sample application allows you to select either a DHT10 through I2C either any other supported DHT through GPIO: + +``` +Select the DHT sensor you want to use: + 1. DHT10 on I2C + 2. DHT11 on GPIO + 3. DHT12 on GPIO + 4. DHT21 on GPIO + 5. DHT22 on GPIO +``` + +Just select the sensor you want to test and use by typing the number. For example, if you want to test a DHT22, type 5. + +Then, you are prompted to type the pin number in the logical schema: + +``` +Which pin do you want to use in the logical pin schema? +``` + +If you want to use the pin 26, then type 26 and enter. This will then create a DHT22 sensor attached to pin 26 and start the measurement. + +Please note that the few first measurements won't be correct, that's totally normal and related to the fact the sensor needs a bit of time to warm up and give data. Those sensors are very sensitive and too long wires, many perturbations, code compile as debug will increase the numbers of bad readings. + + ## Result ![dht22 output](./dht22ex.jpg) From 8b713f1e8d2ea466d9bc6b15373602ef2376d5ba Mon Sep 17 00:00:00 2001 From: Laurent Ellerbach Date: Wed, 26 Aug 2020 08:11:45 +0300 Subject: [PATCH 2/5] Adjusting based on PR feedbacks --- src/devices/Dhtxx/DhtBase.cs | 2 +- src/devices/Dhtxx/README.md | 10 +++- src/devices/Dhtxx/samples/DhtSensor.sample.cs | 49 ++++++------------- 3 files changed, 25 insertions(+), 36 deletions(-) diff --git a/src/devices/Dhtxx/DhtBase.cs b/src/devices/Dhtxx/DhtBase.cs index 007bc8e6d6..a1991de7ee 100644 --- a/src/devices/Dhtxx/DhtBase.cs +++ b/src/devices/Dhtxx/DhtBase.cs @@ -283,7 +283,7 @@ public void Dispose() } else { - _controller.ClosePin(_pin); + _controller?.ClosePin(_pin); } _i2cDevice?.Dispose(); diff --git a/src/devices/Dhtxx/README.md b/src/devices/Dhtxx/README.md index 589640213a..17dd45a86c 100644 --- a/src/devices/Dhtxx/README.md +++ b/src/devices/Dhtxx/README.md @@ -41,7 +41,7 @@ using (Dht11 dht = new Dht11(26)) } } ``` -**Note:** _Specifically on the RPi with the DHT22, 1-Wire works using Raspian but not with Windows 10 IoT Core. The device has to switch the 1-wire pin between input and output and vice versa. It seems that Windows IoT Core OS can't switch the pin direction quick enough. There have been suggestions for using two pins; one for input and one for output. This solution has not been implemented here, but these are some handy links that may help setting that up:_ +**Note:** _On the RPi with any of the DHT sensor, 1-Wire works using Raspian but not with Windows 10 IoT Core. The device has to switch the 1-wire pin between input and output and vice versa. It seems that Windows IoT Core OS can't switch the pin direction quick enough. There have been suggestions for using two pins; one for input and one for output. This solution has not been implemented here, but these are some handy links that may help setting that up:_ - https://github.com/ms-iot/samples/tree/develop/GpioOneWire - And on Hackster.io: https://www.hackster.io/porrey/go-native-c-with-the-dht22-a8e8eb @@ -125,6 +125,14 @@ var controller = new GpioController(PinNumberingScheme.Logical, driver); var dht = new Dht11(4, gpioController: controller); ``` +**My DHT sensor using 1 wire protocol is not working on my Raspberry Pi with Windows 10 IoT Core, what can I do?** + +On the RPi with any of the DHT sensor, 1-Wire works using Raspian but not with Windows 10 IoT Core. The device has to switch the 1-wire pin between input and output and vice versa. It seems that Windows IoT Core OS can't switch the pin direction quick enough. There have been suggestions for using two pins; one for input and one for output. This solution has not been implemented here, but these are some handy links that may help setting that up:_ +- https://github.com/ms-iot/samples/tree/develop/GpioOneWire +- And on Hackster.io: https://www.hackster.io/porrey/go-native-c-with-the-dht22-a8e8eb + +Now if your sensor is an I2C sensor, it should just work perfectly on Windows 10 IoT Core. + ## References * **DHT10** [datasheet (Currently only Chinese)](http://www.aosong.com/userfiles/files/media/DHT10%E8%A7%84%E6%A0%BC%E4%B9%A6.pdf) diff --git a/src/devices/Dhtxx/samples/DhtSensor.sample.cs b/src/devices/Dhtxx/samples/DhtSensor.sample.cs index 554909682f..e24d41910b 100644 --- a/src/devices/Dhtxx/samples/DhtSensor.sample.cs +++ b/src/devices/Dhtxx/samples/DhtSensor.sample.cs @@ -26,7 +26,15 @@ public static void Main(string[] args) if (choice.KeyChar == '1') { Console.WriteLine("Press any key to stop the reading"); - Dht10II2c(); + // Init DHT10 through I2C + I2cConnectionSettings settings = new I2cConnectionSettings(1, Dht10.DefaultI2cAddress); + I2cDevice device = I2cDevice.Create(settings); + + using (Dht10 dht = new Dht10(device)) + { + Dht(dht); + } + return; } @@ -96,6 +104,12 @@ private static void Dht(DhtBase dht) if (dht.IsLastReadSuccessful) { Console.WriteLine($"Temperature: {temp.DegreesCelsius}\u00B0C, Relative humidity: {hum.Percent}%"); + + // WeatherHelper supports more calculations, such as saturated vapor pressure, actual vapor pressure and absolute humidity. + Console.WriteLine( + $"Heat index: {WeatherHelper.CalculateHeatIndex(temp, hum).DegreesCelsius:0.#}\u00B0C"); + Console.WriteLine( + $"Dew point: {WeatherHelper.CalculateDewPoint(temp, hum).DegreesCelsius:0.#}\u00B0C"); } else { @@ -106,38 +120,5 @@ private static void Dht(DhtBase dht) Thread.Sleep(2000); } } - - private static void Dht10II2c() - { - // Init DHT10 through I2C - I2cConnectionSettings settings = new I2cConnectionSettings(1, Dht10.DefaultI2cAddress); - I2cDevice device = I2cDevice.Create(settings); - - using (Dht10 dht = new Dht10(device)) - { - while (!Console.KeyAvailable) - { - var tempValue = dht.Temperature; - var humValue = dht.Humidity; - if (dht.IsLastReadSuccessful) - { - Console.WriteLine($"Temperature: {tempValue.DegreesCelsius:0.#}\u00B0C"); - Console.WriteLine($"Relative humidity: {humValue:0.#}%"); - - // WeatherHelper supports more calculations, such as saturated vapor pressure, actual vapor pressure and absolute humidity. - Console.WriteLine( - $"Heat index: {WeatherHelper.CalculateHeatIndex(tempValue, humValue).DegreesCelsius:0.#}\u00B0C"); - Console.WriteLine( - $"Dew point: {WeatherHelper.CalculateDewPoint(tempValue, humValue).DegreesCelsius:0.#}\u00B0C"); - } - else - { - Console.WriteLine("Error reading DHT sensor"); - } - - Thread.Sleep(2000); - } - } - } } } From a9437ca04bd8632643ad2d838ddb4d330dbffede Mon Sep 17 00:00:00 2001 From: Laurent Ellerbach Date: Wed, 26 Aug 2020 14:41:47 +0300 Subject: [PATCH 3/5] Fixing README nit --- src/devices/Dhtxx/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/devices/Dhtxx/README.md b/src/devices/Dhtxx/README.md index 17dd45a86c..50e217967d 100644 --- a/src/devices/Dhtxx/README.md +++ b/src/devices/Dhtxx/README.md @@ -67,7 +67,7 @@ using (Dht12 dht = new Dht12(device)) $"Heat index: {WeatherHelper.CalculateHeatIndex(tempValue, humValue).Celsius:0.#}\u00B0C"); Console.WriteLine( $"Dew point: {WeatherHelper.CalculateDewPoint(tempValue, humValue).Celsius:0.#}\u00B0C"); -} } + } else { Console.WriteLine("Error reading DHT sensor"); From ec3835bab0f6e99b523f1575784730cae43f6251 Mon Sep 17 00:00:00 2001 From: Laurent Ellerbach Date: Mon, 31 Aug 2020 10:07:19 +0300 Subject: [PATCH 4/5] Adjusting controller to non readonly --- src/devices/Dhtxx/DhtBase.cs | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/devices/Dhtxx/DhtBase.cs b/src/devices/Dhtxx/DhtBase.cs index a1991de7ee..fc691f2d22 100644 --- a/src/devices/Dhtxx/DhtBase.cs +++ b/src/devices/Dhtxx/DhtBase.cs @@ -35,14 +35,14 @@ public abstract class DhtBase : IDisposable protected readonly I2cDevice _i2cDevice; /// - /// related with the . + /// True to dispose the Gpio Controller /// - protected readonly GpioController _controller; + protected readonly bool _shouldDispose; /// - /// True to dispose the Gpio Controller + /// related with the . /// - protected readonly bool _shouldDispose; + protected GpioController _controller; // wait about 1 ms private readonly uint _loopCount = 10000; @@ -280,6 +280,7 @@ public void Dispose() if (_shouldDispose) { _controller?.Dispose(); + _controller = null; } else { From 109fd241eb7eb3e4e15ce1e58f24b1b543165382 Mon Sep 17 00:00:00 2001 From: Laurent Ellerbach Date: Tue, 8 Sep 2020 10:35:46 +0300 Subject: [PATCH 5/5] Fixing disposing to avoid exception if multiple dispose --- src/devices/Dhtxx/DhtBase.cs | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/src/devices/Dhtxx/DhtBase.cs b/src/devices/Dhtxx/DhtBase.cs index fc691f2d22..7ad763c802 100644 --- a/src/devices/Dhtxx/DhtBase.cs +++ b/src/devices/Dhtxx/DhtBase.cs @@ -30,14 +30,14 @@ public abstract class DhtBase : IDisposable protected readonly int _pin; /// - /// I2C device used to communicate with the device + /// True to dispose the Gpio Controller /// - protected readonly I2cDevice _i2cDevice; + protected readonly bool _shouldDispose; /// - /// True to dispose the Gpio Controller + /// I2C device used to communicate with the device /// - protected readonly bool _shouldDispose; + protected I2cDevice _i2cDevice; /// /// related with the . @@ -284,10 +284,17 @@ public void Dispose() } else { - _controller?.ClosePin(_pin); + if (_controller != null) + { + if (_controller.IsPinOpen(_pin)) + { + _controller.ClosePin(_pin); + } + } } _i2cDevice?.Dispose(); + _i2cDevice = null; } } }