Skip to content

Update stale Build HAT firmware and make version/signature reads timing-independent #2554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 3 commits into
base: main
Choose a base branch
from
+31 −6
Draft

Update stale Build HAT firmware and make version/signature reads timing-independent #2554

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
70c4a86
Initial plan
Copilot Jun 2, 2026
a9870bf
Update stale BuildHat firmware and read version/signature line-by-line
Copilot Jun 2, 2026
57fecfb
Clarify MaximumLines rationale in PortReadUntil
Copilot Jun 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 29 additions & 4 deletions src/devices/BuildHat/Brick.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1564,15 +1564,40 @@ private void Reset()
private string GetRawVersion()
{
PortWrite(GetFirmwareVersion);
PortReadLine();
return PortReadExisting();
return PortReadUntil(FirmwareVersion);
}

private string GetRawSignature()
{
PortWrite("signature\r");
PortReadLine();
return PortReadLine();
return PortReadUntil(FirmwareSignature);
}

// Reads complete lines from the port until one contains the expected
// marker. Relying on ReadLine (which waits for the newline terminator)
// instead of a fixed delay or ReadExisting makes the reads independent
// of the board speed and serial timing, which differ a lot between
// boards (for example a faster Raspberry Pi 5 may return before the
// firmware has answered). The firmware can prepend echo, prompt or
// asynchronous lines before the answer, so several lines may need to be
// skipped before the expected one is found.
private string PortReadUntil(string marker)
{
// The expected answer normally comes within the first couple of
// lines; the extra budget covers echo, the prompt and any
// asynchronous port notifications that may be interleaved.
const int MaximumLines = 10;
string line = string.Empty;
for (int i = 0; i < MaximumLines; i++)
{
line = PortReadLine();
if (line.Contains(marker))
{
break;
}
}

return line;
}

private string GetRawVoltage()
Expand Down
Binary file modified src/devices/BuildHat/data/firmware.bin
View file
Open in desktop
Binary file not shown.
2 changes: 1 addition & 1 deletion src/devices/BuildHat/data/signature.bin
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
�;�>g����]mV�V!�Lٙ�� ]NF��鴋�X�|��[�-�;&X�8\Son|�$
��N�.2�wSm�Q/I�Ӎm�)io\�~��I�Az4�ĘɅ�P��w�>\w��L�V�
Expand Down
2 changes: 1 addition & 1 deletion src/devices/BuildHat/data/version
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
1636109636
1737564117