Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the Raspberry Pi detection logic. #766

Open
wants to merge 2 commits into
base: master
from

Conversation

@Frankenslag
Copy link
Contributor

commented Oct 4, 2019

Fixes #661

This PR aims to solve an issue with the detection of a raspberry pi within the GpioController.

At the moment the /dev/cpuinfo is read to identify the Pi but it seems that the Pi info is only made available within Raspbian.

To resolve this the detection mechanism is augmented by reading the device tree to find the Raspberry Pi identifier. If there are any issues with reading the device tree or the identifier is not found then it falls back to original detection logic.

Copy link

left a comment

I believe you should move the check before the loop as this should be a first check before then falling back to the previous method

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.