[build] remove old Xamarin.Android build settings #1358
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewing `Java.Interop`'s build, I noticed some things we can delete now: * Checking for `$(XABuild)`, as this is no longer used * Checking for `$(TargetFramework)=monoandroid10`
There was a problem hiding this comment.
Pull Request Overview
This PR removes obsolete Xamarin.Android build settings from the Java.Interop build configuration. The changes clean up legacy build logic that is no longer needed in the current build system.
- Removes the
XABuildcondition check that was used to conditionally set the target framework - Eliminates the
monoandroid10target framework-specific build target for generating assembly info - Simplifies the build configuration by removing conditional logic for legacy Xamarin.Android scenarios
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Java.Interop/Java.Interop.csproj | Removes XABuild condition check and unconditionally sets target framework |
| src/Java.Interop/Java.Interop.targets | Removes BuildVersionInfo_g_cs target that was specific to monoandroid10 framework |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewing
Java.Interop's build, I noticed some things we can delete now:Checking for
$(XABuild), as this is no longer usedChecking for
$(TargetFramework)=monoandroid10