Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate param NormalizeFeatures for FieldAwareFactorizationMachineBinaryClassificationTrainer.Options #2958

Closed
ganik opened this Issue Mar 14, 2019 · 0 comments

Comments

2 participants
@ganik
Copy link
Member

ganik commented Mar 14, 2019

FieldAwareFactorizationMachineBinaryClassificationTrainer.Options (subclass of TrainerInputBaseWithWeight) has a parameter:
[Argument(ArgumentType.AtMostOnce, HelpText = "Whether to normalize the input vectors so that the concatenation of all fields' feature vectors is unit-length", ShortName = "norm", SortOrder = 6)]
public bool Normalize = true;

However base class TrainerInputBaseWithWeight already has such parameter:
[Argument(ArgumentType.AtMostOnce, HelpText = "Normalize option for the feature column", ShortName = "norm", SortOrder = 5, Visibility = ArgumentAttribute.VisibilityType.EntryPointsOnly)]
internal NormalizeOption NormalizeFeatures = NormalizeOption.Auto;

We have duplicate parameter to indicate whether to normalizes features.

@shauheen shauheen added api bug labels Mar 14, 2019

@shauheen shauheen added this to the 0319 milestone Mar 14, 2019

@shauheen shauheen added this to To do in Project 13 Mar 14, 2019

@shauheen shauheen added this to To do in v0.12 Mar 14, 2019

@ganik ganik self-assigned this Mar 14, 2019

@ganik ganik closed this in #2964 Mar 18, 2019

Project 13 automation moved this from To do to Done Mar 18, 2019

v0.12 automation moved this from To do to Done Mar 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.