Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrubbing of FeatureContributionCalculation and Explainability Catalog #2965

Closed
artidoro opened this Issue Mar 14, 2019 · 0 comments

Comments

2 participants
@artidoro
Copy link
Contributor

artidoro commented Mar 14, 2019

Explainability catalog should be cleaned up.

The MlContext.Model.Explainability catalog was created with the idea that all the model explainability operations would live there.

But it only contains FeatureContributionCalculation because PermutationFeatureImportance lives in the training task specific catalog (i.e. MlContext.BinaryClassification...) because it is task specific.

@rogancarr and @TomFinley agreed that it is not desirable to have a subcatalog with only one transform. And since FeatureContributionCalculation is an estimator/transformer it should probably live under:

MlContext.Transforms.FeatureContributionCalculation

@artidoro artidoro self-assigned this Mar 14, 2019

@artidoro artidoro added the api label Mar 14, 2019

@artidoro artidoro changed the title FeatureContributionCalculation and Explainability Catalog Scrubbing of FeatureContributionCalculation and Explainability Catalog Mar 14, 2019

@shauheen shauheen added this to the 0319 milestone Mar 14, 2019

@shauheen shauheen added this to To do in v0.12 Mar 14, 2019

@shauheen shauheen added this to To do in Project 13 Mar 14, 2019

@artidoro artidoro moved this from To do to In progress in Project 13 Mar 14, 2019

@artidoro artidoro moved this from To do to In progress in v0.12 Mar 14, 2019

Project 13 automation moved this from In progress to Done Mar 19, 2019

v0.12 automation moved this from In progress to Done Mar 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.