Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TrainCatalog and RecommenderCatalog need cleaning #2972

Closed
artidoro opened this Issue Mar 15, 2019 · 0 comments

Comments

2 participants
@artidoro
Copy link
Contributor

artidoro commented Mar 15, 2019

There are some methods in the catalogs that do not respect the naming conventions that we are enforcing in the trainers and the transforms.

The methods that should be fixed are the Evaluate and CrossValidate in particular.

We should rename the parameters accordingly.

@artidoro artidoro added the api label Mar 15, 2019

@artidoro artidoro self-assigned this Mar 15, 2019

@shauheen shauheen added this to the 0319 milestone Mar 15, 2019

@shauheen shauheen added this to In progress in v0.12 Mar 15, 2019

@shauheen shauheen added this to In progress in Project 13 Mar 15, 2019

Project 13 automation moved this from In progress to Done Mar 19, 2019

v0.12 automation moved this from In progress to Done Mar 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.