Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image transfomers don't dispose source image. #3327

Open
codemzs opened this Issue Apr 13, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@codemzs
Copy link
Member

codemzs commented Apr 13, 2019

Image transformers such as grayscale and resize have images as input. After they process input images to produce output image they should dispose the input image because if they don't then we are at mercy of garbage collector cleaning the bitmap objects and if the GC has not done that and some code in the same process tries to open the same image referenced by the bitmap object that is not disposed then we get file in use exception.

@codemzs codemzs added the bug label Apr 13, 2019

@codemzs codemzs added this to the 0419 milestone Apr 13, 2019

@codemzs codemzs self-assigned this Apr 13, 2019

@glebuk

This comment has been minimized.

Copy link
Contributor

glebuk commented Apr 15, 2019

In addition to ensuring that disposing occurs properly, Ensure that also we are opening image in read-only mode so that this is not an exclusive lock.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.