Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using Preview structure and API in samples. #3350

Closed
codemzs opened this Issue Apr 16, 2019 · 0 comments

Comments

Projects
None yet
1 participant
@codemzs
Copy link
Member

codemzs commented Apr 16, 2019

From PR #3307 and @TomFinley 's comment it was learnt that samples should be rewritten to not use "preview" structure because we're writing sample code using a structure expressly and clearly intended purely for debugging in a preview window anyway. There are a number of samples that use preview structure, I will start converting these samples in batches and replace the usage of preview API/structure with something more appropriate like IDataView + getter or Enumerable(with class). We definitely don't want to be educating our users the wrong thing.

CC: @TomFinley @shmoradims @natke @shauheen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.