Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotlinking to blob store #4445

Open
justinormont opened this issue Nov 6, 2019 · 2 comments
Assignees
Labels

Comments

@justinormont
Copy link
Member

@justinormont justinormont commented Nov 6, 2019

We need aka.ms links to the CDN instead of direct links to blob store:

The unit test and sample will stop working in a month as we close down that blob store. (update: found out this is no longer the case -- #4445 (comment))

We should add a check-in test to ensure that no blob-store links are added in the future. All links should be an aka.ms link to the CDN.

@justinormont

This comment has been minimized.

Copy link
Member Author

@justinormont justinormont commented Nov 7, 2019

These six should also follow the aka.ms to CDN route: (consider factoring out this duplicate code)

@gvashishtha

This comment has been minimized.

Copy link

@gvashishtha gvashishtha commented Nov 8, 2019

@yaeldekel It turns out that our storage account will not be affected by US West upgrade, so the only work item is to turn the hotlinks into aka.ms short links. Does this make sense?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.