Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sweepable Parameter can't handle Russia Format #4634

Open
LittleLittleCloud opened this issue Jan 7, 2020 · 4 comments
Open

Sweepable Parameter can't handle Russia Format #4634

LittleLittleCloud opened this issue Jan 7, 2020 · 4 comments
Labels

Comments

@LittleLittleCloud
Copy link
Contributor

@LittleLittleCloud LittleLittleCloud commented Jan 7, 2020

If, for example, in SweepableFloatParam, the raw text value is 0,00123454, it will be parsed into 123454 instead of 0.00123454

See this Issue for further details

@justinormont

This comment has been minimized.

Copy link
Member

@justinormont justinormont commented Jan 7, 2020

I would fix by pushing a culture invariant into the sweepable param:

_valueText = _value.ToString("R");

@LittleLittleCloud

This comment has been minimized.

Copy link
Contributor Author

@LittleLittleCloud LittleLittleCloud commented Jan 8, 2020

In that case we need to add culture invariant to whichever parse from /into string in AutoML. Either we stick to one culture preference inside AutoML, or we just use the default culture setting.

Do you remember the story why we add that culture invariant restriction when parsing sweepable params..

@justinormont

This comment has been minimized.

Copy link
Member

@justinormont justinormont commented Jan 8, 2020

I would stick w/ culture invariant for the lifetime of the string. Currently we have culture invariant on the use of the string, but not the creation. Hence this issue being filed.

Using culture invariant helps in various ways:

  • If we separate the run context (e.g. cluster sweeping) the remote runner machines may be set to English/Russian/etc and needs to share sweep values.
  • Logging -- lets say we want to aggregate and find the best values for a hyperparamer like LearningRate. We'll be receiving values of 0.1234 and 0,1234.
@LittleLittleCloud

This comment has been minimized.

Copy link
Contributor Author

@LittleLittleCloud LittleLittleCloud commented Jan 9, 2020

OK that's convincing, thanks

@gvashishtha gvashishtha added the P3 label Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.