namespace moves for more transforms #1453
Conversation
|
Don't have perms to review, but LGTM. |
| [assembly: EntryPointModule(typeof(LpNormalization))] | ||
|
|
||
| namespace Microsoft.ML.Runtime.Data | ||
| namespace Microsoft.ML.Transforms.Projections |
There was a problem hiding this comment.
Projections [](start = 34, length = 11)
PCA, Whitening, LDA at some extent is also projections. #Resolved
There was a problem hiding this comment.
is LDA projections or text?
#Resolved
There was a problem hiding this comment.
it's projection of text! so Text, (Well it's operate on vector of floats which we get from word bag, but it's main purpose is text related)
I forgot RFF, it's also projection.
Actually Whitening on internal site is stated in Image category.
In reply to: 229512989 [](ancestors = 229512989)
There was a problem hiding this comment.
Well, fun fact, GCN is also stated as Image transform :)
In reply to: 229514079 [](ancestors = 229514079,229512989)
| #endif | ||
| } | ||
|
|
||
| [Fact(Skip = "Execute this test if you want to regenerate the core_manifest and core_ep_list files")] |
There was a problem hiding this comment.
(Skip = "Execute this test if you want to regenerate the core_manifest and core_ep_list files") [](start = 13, length = 95)
oopps #Resolved
| { | ||
| } | ||
|
|
||
| [Fact(Skip = "Execute this test if you want to regenerate CSharpApi file")] |
There was a problem hiding this comment.
[Fact(Skip = "Execute this test if you want to regenerate CSharpApi file")] [](start = 7, length = 76)
revert #Resolved
…earning-1 into namespaceReorg5
ghost
locked as resolved and limited conversation to collaborators
4 participants
More changes related to #1318