Improve documentation for Feature Contribution Calculation #2007
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artidoro
commented
Jan 3, 2019
src/Microsoft.ML.Data/Transforms/FeatureContributionCalculationTransform.cs
Outdated
Show resolved
Hide resolved
shmoradims
reviewed
Jan 3, 2019
src/Microsoft.ML.Data/Transforms/FeatureContributionCalculationTransform.cs
Outdated
Show resolved
Hide resolved
shmoradims
reviewed
Jan 3, 2019
src/Microsoft.ML.Data/Transforms/FeatureContributionCalculationTransform.cs
Outdated
Show resolved
Hide resolved
shmoradims
reviewed
Jan 3, 2019
src/Microsoft.ML.Data/Transforms/FeatureContributionCalculationTransform.cs
Outdated
Show resolved
Hide resolved
rogancarr
reviewed
Jan 3, 2019
src/Microsoft.ML.Data/Transforms/FeatureContributionCalculationTransform.cs
Outdated
Show resolved
Hide resolved
rogancarr
reviewed
Jan 3, 2019
src/Microsoft.ML.Data/Transforms/FeatureContributionCalculationTransform.cs
Outdated
Show resolved
Hide resolved
artidoro
changed the title
rogancarr
reviewed
Jan 7, 2019
src/Microsoft.ML.Data/Transforms/FeatureContributionCalculationTransform.cs
Outdated
Show resolved
Hide resolved
rogancarr
reviewed
Jan 7, 2019
rogancarr
approved these changes
Jan 7, 2019
Contributor
rogancarr
left a comment
rogancarr
left a comment
There was a problem hiding this comment.
Approved with suggestions :)
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1765 and #2016.
In this pull request I update the documentation and some parameter names for FCC.
There were three aspects mentioned in the issues:
topbottommore informative in the constructor of FCC.