Remove Legacy dependency from Microsoft.ML.Benchmarks #2027
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
najeeb-kazmi
commented
Jan 4, 2019
test/Microsoft.ML.Benchmarks/StochasticDualCoordinateAscentClassifierBench.cs
Show resolved
Hide resolved
najeeb-kazmi
commented
Jan 4, 2019
test/Microsoft.ML.Benchmarks/StochasticDualCoordinateAscentClassifierBench.cs
Show resolved
Hide resolved
najeeb-kazmi
commented
Jan 4, 2019
test/Microsoft.ML.Benchmarks/StochasticDualCoordinateAscentClassifierBench.cs
Show resolved
Hide resolved
najeeb-kazmi
commented
Jan 4, 2019
test/Microsoft.ML.Benchmarks/StochasticDualCoordinateAscentClassifierBench.cs
Show resolved
Hide resolved
Member
artidoro
reviewed
Jan 5, 2019
test/Microsoft.ML.Benchmarks/StochasticDualCoordinateAscentClassifierBench.cs
Outdated
Show resolved
Hide resolved
artidoro
approved these changes
Jan 5, 2019
Contributor
artidoro
left a comment
artidoro
left a comment
There was a problem hiding this comment.
Looks good besides a small comment
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the work in PR #1971
This PR removes dependency on Legacy code from Microsoft.ML.Benchmarks.
LegacyPredictionEngineBench.cswas written to mimicPredictionEngineBench.csusing Legacy API after the fact, so just deleting it here.StochasticDualCoordinateAscentClassifierBench.csis rewritten to use new API and remove all Legacy code.