Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Added Dry job for benchmarks CI #2109
requested review from
Jan 10, 2019
left a comment
Overall, looks good to me. I left some comments, mostly related to simplifying the code.
I am really glad that you add these tests! Now the benchmarks are going to become first class citizens of this repo!
It's odd to me that some of the data files are copied to the output, but some aren't. Can we be consistent?
As adam said this is due to the fact that these are some large datasets and we are downloading them fom azure. although i can make the consistent for all the datasets i.e not copying the dataset to output folder.