New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Dry job for benchmarks CI #2109

Merged
merged 10 commits into from Jan 15, 2019

Conversation

Projects
None yet
5 participants
@Anipik
Copy link
Member

Anipik commented Jan 10, 2019

Fixes #2002

This PR will run all the benchmarks in the ci atleast one. This will ensure that the commits have not broken any of the benchmarks

@Anipik Anipik force-pushed the Anipik:dryJob branch 3 times, most recently from 532db8e to 137caae Jan 10, 2019

@adamsitnik
Copy link
Member

adamsitnik left a comment

Overall, looks good to me. I left some comments, mostly related to simplifying the code.

I am really glad that you add these tests! Now the benchmarks are going to become first class citizens of this repo!

@adamsitnik
Copy link
Member

adamsitnik left a comment

I have added some more comments, but in general LGTM!

good job @Anipik !

Show resolved Hide resolved test/Microsoft.ML.Benchmarks.Tests/BenchmarksTest.cs Outdated
Show resolved Hide resolved test/Microsoft.ML.Benchmarks.Tests/BenchmarksTest.cs Outdated
Show resolved Hide resolved test/Microsoft.ML.Benchmarks/Helpers/DataPath.cs Outdated
Show resolved Hide resolved test/Microsoft.ML.Benchmarks/Helpers/DataPath.cs Outdated
Show resolved Hide resolved test/Microsoft.ML.Benchmarks/Helpers/DataPath.cs Outdated
@adamsitnik

This comment has been minimized.

Copy link
Member

adamsitnik commented Jan 10, 2019

@Anipik thanks for fixing all my comments. LGTM! :shipit:

@eerhardt

This comment has been minimized.

Copy link
Member

eerhardt commented Jan 11, 2019

I don't think you need this import anymore, since you are no longer using the data in the file.


Refers to: test/Microsoft.ML.Benchmarks/Microsoft.ML.Benchmarks.csproj:2 in 1adb502. [](commit_id = 1adb502, deletion_comment = False)

@eerhardt

This comment has been minimized.

Copy link
Member

eerhardt commented Jan 11, 2019

<Content Include="..\data\iris.txt" Link="Input\iris.txt">

It's odd to me that some of the data files are copied to the output, but some aren't. Can we be consistent?


Refers to: test/Microsoft.ML.Benchmarks/Microsoft.ML.Benchmarks.csproj:30 in 1adb502. [](commit_id = 1adb502, deletion_comment = False)

@adamsitnik

This comment has been minimized.

Copy link
Member

adamsitnik commented Jan 11, 2019

It's odd to me that some of the data files are copied to the output, but some aren't. Can we be consistent?

@eerhardt some of them are 6.5 GB big. I guess that this is why we have the difference

@Anipik

This comment has been minimized.

Copy link
Member

Anipik commented Jan 11, 2019

It's odd to me that some of the data files are copied to the output, but some aren't. Can we be consistent?

As adam said this is due to the fact that these are some large datasets and we are downloading them fom azure. although i can make the consistent for all the datasets i.e not copying the dataset to output folder.

@Anipik Anipik force-pushed the Anipik:dryJob branch 3 times, most recently from 301744b to b7aeba4 Jan 11, 2019

@Anipik

This comment has been minimized.

Copy link
Member

Anipik commented Jan 14, 2019

@eerhardt can you take a look at this ?

@Anipik Anipik force-pushed the Anipik:dryJob branch from b7aeba4 to ab8231b Jan 14, 2019

#else
[ConditionalFact(typeof(Environment), nameof(Environment.Is64BitProcess))]
Environment.Is64BitProcess; // we don't support 32 bit yet

This comment has been minimized.

@eerhardt

eerhardt Jan 14, 2019

Member

What doesn't support 32-bit?

This comment has been minimized.

@Anipik

Anipik Jan 14, 2019

Member

That's the limitation of BenchmarkDotnet cc @adamsitnik

@eerhardt
Copy link
Member

eerhardt left a comment

:shipit:

@safern

safern approved these changes Jan 15, 2019

Copy link
Member

safern left a comment

LGTM from the YAML perspective.

@Anipik Anipik merged commit 6b9f589 into dotnet:master Jan 15, 2019

2 checks passed

MachineLearning-CI #20190115.7 succeeded
Details
license/cla All CLA requirements met.
Details

@Anipik Anipik deleted the Anipik:dryJob branch Jan 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment