New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing the AdultData LoadColumn, and IrisWithAllFeatures class. #2110

Merged
merged 1 commit into from Jan 14, 2019

Conversation

Projects
4 participants
@sfilipi
Copy link
Member

sfilipi commented Jan 10, 2019

Fixing errors regarding data loading, spotted in the cookbook.

@sfilipi sfilipi requested review from shauheen and shmoradims Jan 10, 2019

@sfilipi sfilipi self-assigned this Jan 10, 2019

[LoadColumn("0", "10"), ColumnName("Features")]
public float FeatureVector { get; }
[LoadColumn(0, 10), ColumnName("Features")]
public float FeatureVector { get; set;}

This comment has been minimized.

@wschin

wschin Jan 10, 2019

Member

Maybe just

Suggested change Beta
public float FeatureVector { get; set;}
public float FeatureVector;

?

This comment has been minimized.

@sfilipi

sfilipi Jan 10, 2019

Member

I'll double-check. I believe it has to be a property, not a field.

[LoadColumn(11)]
public float Target { get; }
public float Target { get; set;}

This comment has been minimized.

@wschin

wschin Jan 10, 2019

Member

Same here. Not sure if having get and set is a convention but I'd remove them for shorter bug equivalent code.

Suggested change Beta
public float Target { get; set;}
public float Target;
@wschin

wschin approved these changes Jan 10, 2019

Copy link
Member

wschin left a comment

:shipit:

@shauheen shauheen added this to In Progress in v0.10 Jan 10, 2019

@singlis
Copy link
Member

singlis left a comment

:shipit:

[LoadColumn("0", "10"), ColumnName("Features")]
public float FeatureVector { get; }
[LoadColumn(0, 10), ColumnName("Features")]
public float FeatureVector { get; set;}

This comment has been minimized.

@shauheen

shauheen Jan 11, 2019

Member

float [](start = 11, length = 5)

I don't think this would work.

@sfilipi

This comment has been minimized.

Copy link
Member

sfilipi commented Jan 14, 2019

merging this to make the doc at pair with the code in the tests, and taking on another pr to refactor the cookbook and verify the examples

@sfilipi sfilipi merged commit aa30210 into dotnet:master Jan 14, 2019

2 checks passed

MachineLearning-CI #20190109.40 succeeded
Details
license/cla All CLA requirements met.

v0.10 automation moved this from In Progress to Done Jan 14, 2019

@eerhardt eerhardt moved this from Done to In Progress in v0.10 Jan 15, 2019

@eerhardt eerhardt moved this from In Progress to Done in v0.10 Jan 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment