New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code coverage support #2116

Closed
wants to merge 55 commits into
base: master
from

Conversation

Projects
None yet
5 participants
@codemzs
Copy link
Member

codemzs commented Jan 10, 2019

This is a WIP PR that adds code coverage support. This change contains code that generates code coverage files. In the next iteration I will add code to upload code coverage files to CodeCov once I know builds pass and a way to disable code coverage if needed.

@codemzs codemzs requested review from ViktorHofer , eerhardt and sharwell Jan 10, 2019

@@ -10,7 +10,7 @@
<Message Importance="High" Text="Running tests ..." />
<MSBuild Targets="VSTest"
Projects="@(Project)"
Properties="VSTestNoBuild=true" />
Properties="VSTestNoBuild=true;Coverage=true;CopyLocalLockFileAssemblies=true" />

This comment has been minimized.

@sharwell

sharwell Jan 11, 2019

Member

CopyLocalLockFileAssemblies=true

Is this not a duplicate of the value in Directory.Build.targets set whenever Coverage is true?

Show resolved Hide resolved test/Directory.Build.targets Outdated

codemzs added some commits Jan 11, 2019

@@ -10,7 +10,7 @@
<Message Importance="High" Text="Running tests ..." />
<MSBuild Targets="VSTest"
Projects="@(Project)"
Properties="VSTestNoBuild=true" />
Properties="VSTestNoBuild=true;Coverage=true;" />

This comment has been minimized.

@eerhardt

eerhardt Jan 11, 2019

Member

There should be a way to shut this off locally, if devs don't want it. #Resolved

This comment has been minimized.

@ViktorHofer

ViktorHofer Jan 13, 2019

Member

Correct, that option needs to be added to the run tool and removed here. #Resolved

Show resolved Hide resolved test/Directory.Build.targets Outdated
Show resolved Hide resolved test/Directory.Build.targets Outdated

<PropertyGroup Condition="'$(Coverage)' == 'true' and '$(Configuration)'=='Release' and '$(OS)' == 'Windows_NT' and '$(TargetArchitecture)' == 'x64'">
<CollectCoverage>true</CollectCoverage>
<CopyLocalLockFileAssemblies>true</CopyLocalLockFileAssemblies>

This comment has been minimized.

@eerhardt

eerhardt Jan 11, 2019

Member

Why is this necessary? Does the coverage tool require it? If so, can you link to information on it?

codemzs added some commits Jan 11, 2019

Show resolved Hide resolved build/Codecov.proj Outdated
Show resolved Hide resolved build/Codecov.proj Outdated

codemzs added some commits Jan 18, 2019

Show resolved Hide resolved build/Codecov.proj Outdated

@codemzs codemzs changed the title WIP Code coverage support Code coverage support Jan 19, 2019

codemzs added some commits Jan 20, 2019

@codecov

This comment has been minimized.

Copy link

codecov bot commented Jan 20, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (master@d11630b). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2116   +/-   ##
=========================================
  Coverage          ?   26.31%           
=========================================
  Files             ?        7           
  Lines             ?     1592           
  Branches          ?        0           
=========================================
  Hits              ?      419           
  Misses            ?     1173           
  Partials          ?        0
Flag Coverage Δ
#Debug 26.31% <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d11630b...93f2955. Read the comment docs.

@codemzs codemzs closed this Jan 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment