Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd validation scenario tests #2503
Conversation
rogancarr
added some commits
Feb 6, 2019
This comment has been minimized.
This comment has been minimized.
codecov
bot
commented
Feb 11, 2019
•
Codecov Report
@@ Coverage Diff @@
## master #2503 +/- ##
==========================================
+ Coverage 71.25% 71.25% +<.01%
==========================================
Files 798 797 -1
Lines 141252 141270 +18
Branches 16112 16112
==========================================
+ Hits 100643 100658 +15
- Misses 36145 36151 +6
+ Partials 4464 4461 -3
|
rogancarr
referenced this pull request
Feb 11, 2019
Open
V1 Scenarios need to be covered by tests #2498
glebuk
self-requested a review
Feb 12, 2019
glebuk
reviewed
Feb 12, 2019
| var preprocessedValidData = preprocessor.Transform(validData); | ||
|
|
||
| // Train the model with a validation set | ||
| var trainedModel = mlContext.Regression.Trainers.FastTree(numTrees: 2) |
This comment has been minimized.
This comment has been minimized.
glebuk
Feb 12, 2019
•
Contributor
trainedModel [](start = 16, length = 12)
add early stopping criteria in the options so that the validation set is actually useful.
Such as https://docs.microsoft.com/en-us/dotnet/api/microsoft.ml.trainers.fasttree.boostedtreeargs.earlystoppingrule?view=ml-dotnet #Closed
glebuk
reviewed
Feb 12, 2019
| // Combine the model | ||
| var model = preprocessor.Append(trainedModel); | ||
|
|
||
| // Score the data sets |
This comment has been minimized.
This comment has been minimized.
glebuk
Feb 12, 2019
•
Contributor
sets [](start = 30, length = 4)
periods at the end of comments throughout. #Closed
rogancarr
added some commits
Feb 13, 2019
rogancarr
merged commit e818e35
into
dotnet:master
Feb 13, 2019
rogancarr
deleted the
rogancarr:2499_validation_scenario_tests
branch
Feb 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
rogancarr commentedFeb 11, 2019
•
edited
This PR adds a test for training with a validation set.
Fixes #2499