New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internalize IDataTransform #2509

Merged
merged 1 commit into from Feb 12, 2019

Conversation

Projects
None yet
3 participants
@Ivanidzo4ka
Copy link
Member

Ivanidzo4ka commented Feb 12, 2019

Hide the unhideable, bestfriend the unfrienable!
fixes #1995

@Ivanidzo4ka Ivanidzo4ka requested review from TomFinley , sfilipi and artidoro Feb 12, 2019

@@ -244,7 +247,8 @@ public override bool IsColumnActive(int col)
/// on multiple input columns.
/// This class provides the implementation of ISchema and IRowCursor.
/// </summary>
public abstract class OneToOneTransformBase : RowToRowMapperTransformBase, ITransposeDataView, ITransformCanSavePfa,
[BestFriend]
internal abstract class OneToOneTransformBase : RowToRowMapperTransformBase, ITransposeDataView, ITransformCanSavePfa,
ITransformCanSaveOnnx

This comment has been minimized.

@artidoro

artidoro Feb 12, 2019

Contributor

There are a few [BestFriend] in this class, if you are doing another iteration, maybe we could make those public and remove the attribute. Not a requirement though.

@artidoro
Copy link
Contributor

artidoro left a comment

:shipit:

@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 12, 2019

Codecov Report

Merging #2509 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2509   +/-   ##
=======================================
  Coverage   71.24%   71.24%           
=======================================
  Files         798      798           
  Lines      141231   141231           
  Branches    16112    16112           
=======================================
  Hits       100623   100623           
  Misses      36142    36142           
  Partials     4466     4466
Flag Coverage Δ
#Debug 71.24% <ø> (ø) ⬆️
#production 67.57% <ø> (ø) ⬆️
#test 85.35% <ø> (ø) ⬆️

@Ivanidzo4ka Ivanidzo4ka requested a review from yaeldekel Feb 12, 2019

@sfilipi
Copy link
Member

sfilipi left a comment

:shipit:

@Ivanidzo4ka Ivanidzo4ka merged commit 5c442a9 into dotnet:master Feb 12, 2019

3 checks passed

MachineLearning-CI #20190211.20 succeeded
Details
MachineLearning-CodeCoverage #20190211.20 succeeded
Details
license/cla All CLA requirements met.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment