Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Lockdown Microsoft.ML.FastTree public surface #2511
### NEW API SURFACE:
@@ Coverage Diff @@ ## master #2511 +/- ## ========================================== + Coverage 71.53% 71.54% +<.01% ========================================== Files 800 800 Lines 141858 141846 -12 Branches 16121 16119 -2 ========================================== + Hits 101476 101479 +3 + Misses 35930 35916 -14 + Partials 4452 4451 -1
2 times, most recently
Feb 15, 2019
TomFinley left a comment
Hi thanks for doing this @codemzs.
If you have time while waiting for a second signoff, the enhancements as suggested by @yaeldekel would be nice to improve our overall code quality, and I'd re-address the issues raised by @zeahmed since certainly having public abstract and virtual methods inside an interface class are not problematic at all.