Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrub text featurizers #2944

Merged
merged 1 commit into from Mar 13, 2019

Conversation

Projects
None yet
3 participants
@wschin
Copy link
Member

wschin commented Mar 13, 2019

Last step of #2832.

@wschin wschin self-assigned this Mar 13, 2019

@wschin wschin requested review from abgoswam and zeahmed Mar 13, 2019

@Ivanidzo4ka Ivanidzo4ka referenced this pull request Mar 13, 2019

Closed

Scrubbing Text related transformers #2832

12 of 12 tasks complete

@wschin wschin requested a review from sfilipi Mar 13, 2019

@codecov

This comment has been minimized.

Copy link

codecov bot commented Mar 13, 2019

Codecov Report

Merging #2944 into master will decrease coverage by <.01%.
The diff coverage is 87.5%.

@@            Coverage Diff             @@
##           master    #2944      +/-   ##
==========================================
- Coverage   72.19%   72.18%   -0.01%     
==========================================
  Files         796      796              
  Lines      142023   142023              
  Branches    16046    16046              
==========================================
- Hits       102527   102521       -6     
- Misses      35116    35121       +5     
- Partials     4380     4381       +1
Flag Coverage Δ
#Debug 72.18% <87.5%> (-0.01%) ⬇️
#production 67.97% <85.71%> (-0.01%) ⬇️
#test 88.3% <100%> (ø) ⬆️
Impacted Files Coverage Δ
...icrosoft.ML.Functional.Tests/DataTransformation.cs 100% <100%> (ø) ⬆️
...oft.ML.Transforms/Text/TextFeaturizingEstimator.cs 88.7% <85.71%> (ø) ⬆️
...c/Microsoft.ML.FastTree/Utils/ThreadTaskManager.cs 79.48% <0%> (-20.52%) ⬇️
src/Microsoft.ML.Maml/MAML.cs 24.75% <0%> (-1.46%) ⬇️
...soft.ML.Data/DataLoadSave/Text/TextLoaderCursor.cs 84.9% <0%> (+0.2%) ⬆️
src/Microsoft.ML.Transforms/Text/LdaTransform.cs 90.37% <0%> (+0.63%) ⬆️
1 similar comment
@codecov

This comment has been minimized.

Copy link

codecov bot commented Mar 13, 2019

Codecov Report

Merging #2944 into master will decrease coverage by <.01%.
The diff coverage is 87.5%.

@@            Coverage Diff             @@
##           master    #2944      +/-   ##
==========================================
- Coverage   72.19%   72.18%   -0.01%     
==========================================
  Files         796      796              
  Lines      142023   142023              
  Branches    16046    16046              
==========================================
- Hits       102527   102521       -6     
- Misses      35116    35121       +5     
- Partials     4380     4381       +1
Flag Coverage Δ
#Debug 72.18% <87.5%> (-0.01%) ⬇️
#production 67.97% <85.71%> (-0.01%) ⬇️
#test 88.3% <100%> (ø) ⬆️
Impacted Files Coverage Δ
...icrosoft.ML.Functional.Tests/DataTransformation.cs 100% <100%> (ø) ⬆️
...oft.ML.Transforms/Text/TextFeaturizingEstimator.cs 88.7% <85.71%> (ø) ⬆️
...c/Microsoft.ML.FastTree/Utils/ThreadTaskManager.cs 79.48% <0%> (-20.52%) ⬇️
src/Microsoft.ML.Maml/MAML.cs 24.75% <0%> (-1.46%) ⬇️
...soft.ML.Data/DataLoadSave/Text/TextLoaderCursor.cs 84.9% <0%> (+0.2%) ⬆️
src/Microsoft.ML.Transforms/Text/LdaTransform.cs 90.37% <0%> (+0.63%) ⬆️
[Argument(ArgumentType.AtMostOnce, HelpText = "Casing text using the rules of the invariant culture.", ShortName = "case", SortOrder = 5)]
public CaseMode TextCase = TextNormalizingEstimator.Defaults.Mode;
[Argument(ArgumentType.AtMostOnce, HelpText = "Casing text using the rules of the invariant culture.", Name="TextCase", ShortName = "case", SortOrder = 5)]
public CaseMode CaseMode = TextNormalizingEstimator.Defaults.Mode;

This comment has been minimized.

@abgoswam

abgoswam Mar 13, 2019

Member

CaseMode [](start = 28, length = 8)

does it make sense to call it TextCaseMode ? #WontFix

This comment has been minimized.

@wschin

wschin Mar 13, 2019

Author Member

This is CaseMode in TextFeaturizingEstimator, I'd say Text will look a bit redundant.


In reply to: 265302608 [](ancestors = 265302608)

@abgoswam
Copy link
Member

abgoswam left a comment

:shipit:

@sfilipi
Copy link
Member

sfilipi left a comment

:shipit:

@wschin wschin merged commit d6c4872 into dotnet:master Mar 13, 2019

3 checks passed

MachineLearning-CI #20190313.18 succeeded
Details
MachineLearning-CodeCoverage #20190313.18 succeeded
Details
license/cla All CLA requirements met.
Details

@wschin wschin deleted the wschin:polish-text-feat branch Mar 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.