Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FeaturizeText: Add instructions to turn off char- or word-gram generation to the tooltip. #2947

Merged
merged 2 commits into from Mar 13, 2019

Conversation

Projects
None yet
3 participants
@rogancarr
Copy link
Contributor

rogancarr commented Mar 13, 2019

Adding a note on how to turn off char-grams and word-grams in FeaturizeText.

Fixes #2946

@rogancarr rogancarr requested review from zeahmed and wschin Mar 13, 2019

@@ -128,6 +128,7 @@ public sealed class Options : TransformInputBase

/// <summary>
/// Ngram feature extractor to use for words (WordBag/WordHashBag).
/// Set to null to turn off n-gram generation for words.

This comment has been minimized.

@wschin

wschin Mar 13, 2019

Member
Suggested change
/// Set to null to turn off n-gram generation for words.
/// Set to <see langword="null"> to turn off n-gram generation for words.
``` #Resolved
@@ -160,6 +161,7 @@ public WordBagEstimator.Options WordFeatureExtractor

/// <summary>
/// Ngram feature extractor to use for characters (WordBag/WordHashBag).
/// Set to null to turn off n-gram generation for characters.

This comment has been minimized.

@wschin

wschin Mar 13, 2019

Member

Please make it langword. #Resolved

@wschin

wschin approved these changes Mar 13, 2019

Copy link
Member

wschin left a comment

Two minor comments left. Please address them before merging. Thanks.

@codecov

This comment has been minimized.

Copy link

codecov bot commented Mar 13, 2019

Codecov Report

Merging #2947 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2947      +/-   ##
==========================================
+ Coverage   72.19%   72.19%   +<.01%     
==========================================
  Files         796      796              
  Lines      142020   142038      +18     
  Branches    16047    16047              
==========================================
+ Hits       102527   102544      +17     
- Misses      35112    35113       +1     
  Partials     4381     4381
Flag Coverage Δ
#Debug 72.19% <ø> (ø) ⬆️
#production 67.98% <ø> (ø) ⬆️
#test 88.3% <ø> (ø) ⬆️
Impacted Files Coverage Δ
...oft.ML.Transforms/Text/TextFeaturizingEstimator.cs 88.7% <ø> (ø) ⬆️
src/Microsoft.ML.Transforms/Text/LdaTransform.cs 89.74% <0%> (-0.64%) ⬇️
...rosoft.ML.Tests/TrainerEstimators/FAFMEstimator.cs 100% <0%> (ø) ⬆️
src/Microsoft.ML.Maml/MAML.cs 26.21% <0%> (+1.45%) ⬆️
...actorizationMachine/FactorizationMachineCatalog.cs 66.66% <0%> (+16.66%) ⬆️

@rogancarr rogancarr requested a review from singlis Mar 13, 2019

@singlis
Copy link
Member

singlis left a comment

:shipit:

@rogancarr rogancarr merged commit 687ca53 into dotnet:master Mar 13, 2019

2 of 3 checks passed

MachineLearning-CodeCoverage in progress
Details
MachineLearning-CI #20190313.41 succeeded
Details
license/cla All CLA requirements met.

@rogancarr rogancarr deleted the rogancarr:2946_detail_chargramAndWordgram_offButton branch Mar 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.