Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean FeatureContributionCalculation and PermutationFeatureImportance #2966

Merged
merged 7 commits into from Mar 19, 2019

Conversation

Projects
None yet
3 participants
@artidoro
Copy link
Contributor

artidoro commented Mar 14, 2019

Fixes #2965.

In this PR:

  1. I move and rename the extension MlContext.Model.Explainability.FeatureContributionCalculation to MlContext.Transforms.CalculateFeatureContribution.

  2. I also remove the MlContext.Model.Explainability catalog.

  3. Clean up the FeatureContributionCalculation extension

  4. Clean up PFI extensions

@artidoro artidoro added the api label Mar 14, 2019

@artidoro artidoro added this to the 0319 milestone Mar 14, 2019

@artidoro artidoro self-assigned this Mar 14, 2019

@artidoro artidoro changed the title Move FeatureContributionCalculation Move and scrubb FeatureContributionCalculation Mar 14, 2019

@artidoro artidoro changed the title Move and scrubb FeatureContributionCalculation Move and clean FeatureContributionCalculation Mar 14, 2019

@artidoro artidoro changed the title Move and clean FeatureContributionCalculation Clean FeatureContributionCalculation and PermutationFeatureImportance Mar 14, 2019

@rogancarr

This comment has been minimized.

Copy link
Contributor

rogancarr commented Mar 15, 2019

Looking good! Just a few questions / comments. #Resolved

@artidoro artidoro force-pushed the artidoro:explainability branch from 574925e to ccf8fdd Mar 18, 2019

@codecov

This comment has been minimized.

Copy link

codecov bot commented Mar 18, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (master@0831865). Click here to learn what that means.
The diff coverage is 96.49%.

@@            Coverage Diff            @@
##             master    #2966   +/-   ##
=========================================
  Coverage          ?   72.35%           
=========================================
  Files             ?      803           
  Lines             ?   143295           
  Branches          ?    16155           
=========================================
  Hits              ?   103682           
  Misses            ?    35189           
  Partials          ?     4424
Flag Coverage Δ
#Debug 72.35% <96.49%> (?)
#production 68.07% <93.1%> (?)
#test 88.52% <100%> (?)
Impacted Files Coverage Δ
.../Microsoft.ML.Data/Model/ModelOperationsCatalog.cs 97.27% <ø> (ø)
...ansforms/PermutationFeatureImportanceExtensions.cs 97.93% <100%> (ø)
...st/Microsoft.ML.Functional.Tests/Explainability.cs 100% <100%> (ø)
...rosoft.ML.Data/Transforms/ExplainabilityCatalog.cs 100% <100%> (ø)
...est/Microsoft.ML.Tests/FeatureContributionTests.cs 98.55% <100%> (ø)
...forms/FeatureContributionCalculationTransformer.cs 73.55% <81.81%> (ø)

@artidoro artidoro requested a review from rogancarr Mar 18, 2019

@rogancarr
Copy link
Contributor

rogancarr left a comment

:shipit:

@Ivanidzo4ka
Copy link
Member

Ivanidzo4ka left a comment

:shipit:

@artidoro artidoro merged commit 1a89468 into dotnet:master Mar 19, 2019

2 of 3 checks passed

MachineLearning-CodeCoverage in progress
Details
MachineLearning-CI #20190319.5 succeeded
Details
license/cla All CLA requirements met.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.