Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update release branch #3333

merged 73 commits into from Apr 14, 2019


None yet
Copy link

shauheen commented Apr 13, 2019

This PR updates the 1.0 release branch with changes from Master branch.

shauheen and others added some commits Mar 26, 2019

Fix missing ExampleWeightColumnName in the advanced Options for some …
…trainers (#3104)

* fixed issue, added tests

* fix review comments

* updating equality checks for floats
Update VBuffer documentation (#3136)
* Improve VBuffer documentation.
* Improve the XML documentation for VBuffer/VBufferEditor.
* Update the "best practices" documentation to reflect recent changes.
* Update parameter names to avoid abbreviations, e.g., src => source and suchlike.
Move Normalizer extension method from experimental to stable nuget an…
…d remove Normalizer generic APIs (#3118)

* Move Normalizer extension method from experimental to stable nuget.

* Cleanup unused method in Normalizer Estimator.

* remove normalizer estimator catalog methods that take enum as parameter.

* Remove Microsoft.ML.Experimental references in CS files.

* merge fix.

* cleanup.

* cleanup.

* PR feedback.
Adding release notes for RC1 (#3176)
* Adding release notes for RC1
Fix IncludeBuildNumberInPackageVersion for official builds (#3182)
When doing an official build and setting a AzDO build variable, the variable turns into an environment variable. When MSBuild props/targets files declare a property, if they don't check if the property is already set, the MSBuild props file will override the environment variable. This causes the AzDO build variable to be ignored.

Adding a check if the IncludeBuildNumberInPackageVersion property is already set before setting it in Directory.Build.props.
Multi-column mapping API for normalizer estimators. (#3172)
* Multi-column mapping for Normalizer estimators.

* XML comment.

* revert Program.cs

* Add copyright header.

* Add tests.

* PR feedback.

* cleanup.

* PR feedback.
Samples and unit test for image-related transform estimators (#3165)
* updating image samples

* fix review comments (print preview)

* fix comments (minor nits)

* fix review comments (whitespaces)
Conversion catalog samples (#3167)
* adding a sample for convert MultiColumns. Moving files around.

* Adjust the samples about ValueMapping

* Addressing PR comments
Key type documentation. (#3194)
* Key type documentation.
Samples for categorical transform estimators (#3179)
* categorical transform estimators

* review comments

* fix review comments

* modify samples namespace
Samples for FeatureSelection transform estimators (#3184)
* samples for FeatureSelection transform estimators

* fix review comments

* fix review comments

* review comments

* take care of review comments

* fix copy paste output error

codemzs and others added some commits Apr 11, 2019

Extend Gam Samples (#3281)
* Adding Regression and Binary Classification GAM samples.
Merge branch 'master' into RC2
# Conflicts:
#	build/BranchInfo.props
#	docs/samples/Microsoft.ML.Samples/Dynamic/DataOperations/BootstrapSample.cs
#	docs/samples/Microsoft.ML.Samples/Dynamic/Normalizer.cs
#	docs/samples/Microsoft.ML.Samples/Dynamic/PermutationFeatureImportance/PFIRegressionExample.cs
#	docs/samples/Microsoft.ML.Samples/Dynamic/PermutationFeatureImportance/PfiBinaryClassificationExample.cs
#	docs/samples/Microsoft.ML.Samples/Dynamic/Trainers/BinaryClassification/StochasticDualCoordinateAscentNonCalibrated.cs
#	src/Microsoft.ML.Transforms/NormalizerCatalog.cs

This comment has been minimized.

Copy link

codemzs commented Apr 13, 2019


@shauheen shauheen requested review from eerhardt, TomFinley and glebuk Apr 13, 2019

Copy link

eerhardt left a comment

I looked through all the high-level folder changes and at each change to files in the src folder. This looks good to me.

Copy link

TomFinley left a comment

Thank you good sir.


This comment has been minimized.

Copy link

karuzzo commented on 51fc8b2 Apr 22, 2019

Hi? i wont use it on x86 cpu. Is the x86 version of CpuMath dll planned?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.