Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SymSGD documentation #3345

Merged
merged 3 commits into from Apr 17, 2019

Conversation

Projects
None yet
3 participants
@Ivanidzo4ka
Copy link
Member

Ivanidzo4ka commented Apr 15, 2019

Documentation for SymSGD towards #2522

@Ivanidzo4ka Ivanidzo4ka requested review from wschin and shmoradims Apr 15, 2019

/// | Is normalization required? | Yes |
/// | Is caching required? | No |
/// | Required NuGet in addition to Microsoft.ML |Microsoft.ML.Mkl.Components |
/// ### Training Algorithm Details

This comment has been minimized.

Copy link
@shmoradims

shmoradims Apr 16, 2019

Contributor

/// [](start = 4, length = 4)

extra line after the table please.

@shmoradims shmoradims requested a review from natke Apr 16, 2019

@shmoradims
Copy link
Contributor

shmoradims left a comment

:shipit:

@@ -4,5 +4,5 @@ The input label column data must be <xref:System.Single>. This trainer outputs t
| Output Column Name | Column Type | Description|
| -- | -- | -- |
| `Score` | <xref:System.Single> | The unbounded score that was calculated by the trainer to determine the prediction.|
| `PredictedLabel` | <xref:System.Boolean> | The label predicted by the trainer. `false` maps to negative score and `true` maps to positive score.|
| `PredictedLabel` | <xref:System.Boolean> | The label predicted by the trainer. `false` maps to negative score and `true` maps to positive score.|
| `Probability` | <xref:System.Single> | The probability of the score in range [0, 1].|

This comment has been minimized.

Copy link
@wschin

wschin Apr 16, 2019

Member
Suggested change
| `Probability` | <xref:System.Single> | The probability of the score in range [0, 1].|
| `Probability` | <xref:System.Single> | The probability of having true as the label. Probability value is in range [0, 1].|
@wschin

wschin approved these changes Apr 16, 2019

Copy link
Member

wschin left a comment

Approved with a minor correction.

Ivanidzo4ka added some commits Apr 16, 2019

address comments.
make it build
@codecov

This comment has been minimized.

Copy link

codecov bot commented Apr 16, 2019

Codecov Report

Merging #3345 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3345      +/-   ##
==========================================
- Coverage    72.7%   72.69%   -0.01%     
==========================================
  Files         807      807              
  Lines      145172   145172              
  Branches    16225    16225              
==========================================
- Hits       105541   105537       -4     
- Misses      35217    35220       +3     
- Partials     4414     4415       +1
Flag Coverage Δ
#Debug 72.69% <ø> (-0.01%) ⬇️
#production 68.23% <ø> (-0.01%) ⬇️
#test 88.97% <ø> (ø) ⬆️
Impacted Files Coverage Δ
src/Microsoft.ML.Mkl.Components/VectorWhitening.cs 80.54% <ø> (ø) ⬆️
...t.ML.Mkl.Components/SymSgdClassificationTrainer.cs 76.16% <ø> (ø) ⬆️
...ents.StaticPipe/VectorWhiteningStaticExtensions.cs 100% <ø> (ø) ⬆️
...icrosoft.ML.Mkl.Components/MklComponentsCatalog.cs 65.71% <ø> (ø) ⬆️
...soft.ML.Transforms/Text/WordEmbeddingsExtractor.cs 87.52% <0%> (-0.91%) ⬇️
...classClassification/MulticlassNaiveBayesTrainer.cs 87.17% <0%> (ø) ⬆️
...oft.ML.StandardTrainers/StandardTrainersCatalog.cs 92.34% <0%> (ø) ⬆️

@Ivanidzo4ka Ivanidzo4ka merged commit 82dd186 into dotnet:master Apr 17, 2019

3 checks passed

MachineLearning-CI #20190416.42 succeeded
Details
MachineLearning-CodeCoverage #20190416.24 succeeded
Details
license/cla All CLA requirements met.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.